Control: tag -1 confirmed patch

I confirm that grub-pc-dbg is broken - the kernel.exec and *.image files
are stripped.  Similarly in other -dbg packages:

grub-coreboot-dbg/usr/lib/grub/i386-coreboot/kernel.exec:               ELF 
32-bit LSB executable, Intel i386, version 1 (SYSV), statically linked, stripped
grub-ieee1275-dbg/usr/lib/grub/i386-ieee1275/kernel.exec:               ELF 
32-bit LSB executable, Intel i386, version 1 (SYSV), statically linked, stripped
grub-xen-dbg/usr/lib/grub/x86_64-xen/kernel.exec:                       ELF 
64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped
grub-xen-dbg/usr/lib/grub/i386-xen_pvh/kernel.exec:                     ELF 
32-bit LSB executable, Intel i386, version 1 (SYSV), statically linked, stripped
grub-xen-dbg/usr/lib/grub/i386-xen/kernel.exec:                         ELF 
32-bit LSB executable, Intel i386, version 1 (SYSV), statically linked, stripped

Possibly dh_strip no longer treats legacy *-dbg packages as special?

In any case, this can be fixed by adding .exec and .image to the
dh_strip exclusions.  This is what the attached patch does.

Ben.

-- 
Ben Hutchings
[W]e found...that it wasn't as easy to get programs right as we had
thought. I realized that a large part of my life from then on was going
to be spent in finding mistakes in my own programs.
                                                 - Maurice Wilkes, 1949
diff -Nru grub2-2.12/debian/changelog grub2-2.12/debian/changelog
--- grub2-2.12/debian/changelog	2025-03-15 14:55:29.000000000 +0100
+++ grub2-2.12/debian/changelog	2025-04-26 13:50:10.000000000 +0200
@@ -1,3 +1,10 @@
+grub2 (2.12-7.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * debian/rules: Do not strip .exec or .image files (Closes: #1072167)
+
+ -- Ben Hutchings <b...@debian.org>  Sat, 26 Apr 2025 13:50:10 +0200
+
 grub2 (2.12-7) unstable; urgency=medium
 
   [ Mate Kukri ]
diff -Nru grub2-2.12/debian/rules grub2-2.12/debian/rules
--- grub2-2.12/debian/rules	2025-03-15 14:55:29.000000000 +0100
+++ grub2-2.12/debian/rules	2025-04-26 13:50:10.000000000 +0200
@@ -578,7 +578,7 @@
 	dh_bugfiles $(patsubst %,-N%,$(filter grub-efi-%-signed-template,$(BUILD_PACKAGES))) -A
 
 override_dh_strip:
-	dh_strip -X/usr/lib/grub-xen/grub-x86_64-xen.bin -X/usr/lib/grub-xen/grub-i386-xen_pvh.bin -X/usr/lib/grub-xen/grub-i386-xen.bin
+	dh_strip -X/usr/lib/grub-xen/grub-x86_64-xen.bin -X/usr/lib/grub-xen/grub-i386-xen_pvh.bin -X/usr/lib/grub-xen/grub-i386-xen.bin -X.exec -X.image
 
 override_dh_shlibdeps:
 	dh_shlibdeps -X.module

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to