On 23 Apr 2025, at 06:20, Phil Wyett <philip.wy...@kathenas.org> wrote:

> Review of upload: 2025-04-22 11:11
> 
> For information about the tests run, see:
> 
> https://wiki.debian.org/PhilWyett/DebianMentoring
> 
> Test 4 (sbuild): Information only
> 
> lintian:
> 
> W: redwax-tool source: build-depends-on-obsolete-package Build-Depends: pkg-
> config => pkgconf
> N: 
> N:   The package build-depends on a package that has been superseded. If the
> N:   superseded package is part of an ORed group, it should not be the first
> N:   package in the group.
> N: 
> N:   Visibility: warning
> N:   Show-Always: no
> N:   Check: fields/package-relations

Fixed this one.

> I: redwax-tool source: out-of-date-standards-version 4.7.0 (released 
> 2024-04-07)
> (current is 4.7.2)
> N: 
> N:   The source package refers to a Standards-Version older than the one that
> N:   was current at the time the package was created (according to the
> N:   timestamp of the latest debian/changelog entry). Please consider updating
> N:   the package to current Policy and setting this control field
> N:   appropriately.
> N:   
> N:   If the package is already compliant with the current standards, you don't
> N:   have to re-upload the package just to adjust the Standards-Version 
> control
> N:   field. However, please remember to update this field next time you upload
> N:   the package.
> N:   
> N:   See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
> N:   debian-policy package for a summary of changes in newer versions of
> N:   Policy.
> N: 
> N:   Please refer to
> N:   https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
> N:   details.
> N: 
> N:   Visibility: info
> N:   Show-Always: no
> N:   Check: fields/standards-version

Fixed this one too.

> Test 6 (debian/watch): Information only
> 
> philwyett@ks-tarkin:~/Development/builder/debian/redwax-tool-0.9.9$ uscan 
> --dehs
> uscan warn: Found multiple concatenated ASCII Armor blocks in
>  debian/upstream/signing-key.asc, which is not an interoperable construct.
>  See <https://tests.sequoia-pgp.org/results.html#ASCII_Armor>.
>  Please concatenate them into a single ASCII Armor block. For example:
>    sq keyring merge --overwrite --output debian/upstream/signing-key.asc \
>      debian/upstream/signing-key.asc
> <dehs>
> <package>redwax-tool</package>
> <debian-uversion>0.9.9</debian-uversion>
> <debian-mangled-uversion>0.9.9</debian-mangled-uversion>
> <upstream-version>0.9.9</upstream-version>
> <upstream-url>https://redwax.eu/dist/rt/redwax-tool-0.9.9.tar.bz2</upstream-url>
> <status>up to date</status>
> </dehs>

This is fixed.

> Test 7 (licenserecon): Information only
> 
> philwyett@ks-tarkin:~/Development/builder/debian/redwax-tool-0.9.9$ lrc
> en: Versions: licenserecon '4.2'  licensecheck '3.3.9-1'
> 
> Parsing Source Tree  ....
> Reading d/copyright  ....
> Running licensecheck ....
> 
> d/copyright      | licensecheck
> 
> __AUTO_PERMISSIVE__| X11               build-aux/install-sh
> Apache-2.0       | GPL-2+ with Libtool exception build-aux/ltmain.sh
> __AUTO_PERMISSIVE__| FSFUL             configure
> Apache-2.0       | FSFAP             INSTALL
> Apache-2.0       | (FSFULLR and/or GPL-2+) with Libtool exception 
> m4/libtool.m4
> Apache-2.0       | FSFULLR           m4/lt~obsolete.m4
> Apache-2.0       | FSFULLR           m4/ltoptions.m4
> Apache-2.0       | FSFULLR           m4/ltsugar.m4
> Apache-2.0       | FSFULLR           m4/ltversion.m4

Is this ok as it is or is there something I need to fix?

All the autoconf generated stuff can be tricky to work with, has confused me a 
little.

> Summary
> =======
> 
> Looking promising. Above are a number of things you may wish to look at.

Thanks for this, it is much appreciated.

Regards,
Graham
--

Reply via email to