Hi Jeremy, On Tue, Apr 22, 2025 at 04:47:28PM -0400, Jeremy Bícha wrote: > The meson.build part of your patch was already applied upstream years > ago. (gnome-recipes hasn't had an upstream release since 2020.) > > https://gitlab.gnome.org/GNOME/recipes/-/commit/3ad8307
Sorry for not having checked. > It is missing your removal of #include "config.h" . What is the > significance of that change? Is the change necessary here? The config.h files usually contains architecture-specific properties. It may even #include other headers that are only available for a particular architecture. Keeping it bears a risk of things failing subtly. By not #including it and knowing that it works anyway, we generally eliminate that risk. It's not a critical aspect but more like making sure it works in future. Helmut
