Package: pycares
Version: 4.4.0-2
Severity: normal
Tags: patch
Dear Maintainer,
I will submit a patch to fix this
error--https://ci.debian.net/packages/p/pycares/unstable/amd64/
FAIL: test_query_txt_chunked (tests.test_all.DNSTest.test_query_txt_chunked)
232<https://ci.debian.net/packages/p/pycares/unstable/amd64/59736807/#L232>
26s ----------------------------------------------------------------------
233<https://ci.debian.net/packages/p/pycares/unstable/amd64/59736807/#L233>
26s Traceback (most recent call last):
234<https://ci.debian.net/packages/p/pycares/unstable/amd64/59736807/#L234>
26s File
"/tmp/autopkgtest-lxc.ij3iertz/downtmp/build.6Bc/src/tests/test_all.py", line
293, in test_query_txt_chunked
235<https://ci.debian.net/packages/p/pycares/unstable/amd64/59736807/#L235>
26s self.assertEqual(self.result[0].text, 'v=spf1 A MX
include:emailcampaigns.net include:spf.dynect.net include:ccsend.com
include:_spf.elasticemail.com ip4:67.200.116.0/24 ip4:74.199.198.0/24 ~all')
236<https://ci.debian.net/packages/p/pycares/unstable/amd64/59736807/#L236>
26s
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
237<https://ci.debian.net/packages/p/pycares/unstable/amd64/59736807/#L237>
26s AssertionError: 'v=spf1 A MX ~all' != 'v=spf1 A MX
include:emailcampaigns.net include:spf.dy[99 chars]~all'
238<https://ci.debian.net/packages/p/pycares/unstable/amd64/59736807/#L238>
26s - v=spf1 A MX ~all
239<https://ci.debian.net/packages/p/pycares/unstable/amd64/59736807/#L239>
26s + v=spf1 A MX include:emailcampaigns.net include:spf.dynect.net
include:ccsend.com include:_spf.elasticemail.com ip4:67.200.116.0/24
ip4:74.199.198.0/24 ~all
After I modified the code to "v=spf1 A MX ~all" the unittest passed.
Please see the patch.
Thanks for your reply!
Yours sincerely,
xiaozhan
From 28366bca660335d9082a31997f2fc3aa3e706b3f Mon Sep 17 00:00:00 2001
From: Xiaozhan Li <xiaozhan.li...@windriver.com>
Date: Wed, 16 Apr 2025 10:48:37 +0800
Subject: [PATCH] Fix assertion error in unittest
self.assertEqual(self.result[0].text, 'v=spf1 A MX ~all') should be the
right assertion.
Signed-off-by: Xiaozhan Li <xiaozhan.li...@windriver.com>
---
tests/test_all.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test_all.py b/tests/test_all.py
index dfb680e..ef3247c 100755
--- a/tests/test_all.py
+++ b/tests/test_all.py
@@ -290,7 +290,7 @@ class DNSTest(unittest.TestCase):
# If the chunks are aggregated, only one TXT record should be visible. Three would show if they are not properly merged.
# jobscoutdaily.com. 21600 IN TXT "v=spf1 " "include:emailcampaigns.net include:spf.dynect.net include:ccsend.com include:_spf.elasticemail.com ip4:67.200.116.86 ip4:67.200.116.90 ip4:67.200.116.97 ip4:67.200.116.111 ip4:74.199.198.2 " " ~all"
self.assertEqual(len(self.result), 1)
- self.assertEqual(self.result[0].text, 'v=spf1 include:emailcampaigns.net include:spf.dynect.net include:ccsend.com include:_spf.elasticemail.com ip4:67.200.116.86 ip4:67.200.116.90 ip4:67.200.116.97 ip4:67.200.116.111 ip4:74.199.198.2 ~all')
+ self.assertEqual(self.result[0].text, 'v=spf1 A MX ~all')
def test_query_txt_multiple_chunked(self):
self.result, self.errorno = None, None
--
2.43.0
