Source: vhba-module
Version: 20240917-1
Severity: normal
Tags: patch
Hi,
I have a small fix for the -dkms package.
The postinst script tries to load the module. This should not happen if
the package gets installed in a chroot (e.g. during QA) because it would
load a module into the host kernel.
Another question: what do you think about hosting the packaging in a git
repository on salsa.debian.org along with the QA support it could get
there? vhba-dkms is one of the last -dkms packages not hosted in git.
I could do the initial import and grant you the neccessary permissions
if you tell me your salsa account name.
If you agree, please don't upload the above fix right now as I'd like to
do the import first and add the corresponding metadata to the package.
Andreas
>From 01f1f809b19b22c8aa6199acfbb9c7fa2a56623f Mon Sep 17 00:00:00 2001
From: Andreas Beckmann <a...@debian.org>
Date: Sat, 29 Mar 2025 17:42:20 +0100
Subject: [PATCH] vhba-dkms: do not run modprobe inside a chroot environment
If vhba-dkms is installed in a chroot environment, do not attempt to
load the module in the host kernel.
---
debian/changelog | 6 ++++++
debian/vhba-dkms.postinst | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/debian/changelog b/debian/changelog
index 5c9cb72..15cbcb6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+vhba-module (20240917-2) UNRELEASED; urgency=medium
+
+ * vhba-dkms: Do not run modprobe inside a chroot environment.
+
+ -- Andreas Beckmann <a...@debian.org> Sat, 29 Mar 2025 17:39:14 +0100
+
vhba-module (20240917-1) unstable; urgency=medium
* New upstream version, closes: #1081379.
diff --git a/debian/vhba-dkms.postinst b/debian/vhba-dkms.postinst
index 6435435..b92dc6c 100644
--- a/debian/vhba-dkms.postinst
+++ b/debian/vhba-dkms.postinst
@@ -8,7 +8,7 @@ mywarning ()
echo "WARNING: $1" >&2
}
-if [ "$1" = "configure" ]; then
+if [ "$1" = "configure" ] && ! ischroot ; then
# try to load the module
if test -d "/sys/module/vhba"; then
mywarning "Reboot required to load new vhba module."
--
2.39.5
