Hi! On Fri, 2025-03-28 at 13:01:47 +0100, Chris Hofstaedtler wrote: > * Bill Allombert <ballo...@debian.org> [250328 10:33]: > > On Fri, Mar 28, 2025 at 10:02:46AM +0100, Guillem Jover wrote: > > > Source: popularity-contest > > > Source-Version: 1.78 > > > Severity: normal
> > > Was checking the git repo, and noticed that the package cannot be > > > built from a git checkout, as it is at least missing the > > > debian-popcon.gpg file. > > This is intended. You can get this file from the Debian source package. > > This way, there is only one official source. Hmm, I'm not sure I really understand this rationale, of making the git repo unbuildable to mark it as non-official. When I noticed the missing file, I didn't expect the git repo to contain all the files (such as I would not expect to find auto-generated autotools artifacts or similar), but at least I was expecting a way to fetch that from its canonical location, or to generate it or similar (I looked for example for a make rule to do that). After not finding anything, I was rather confused and wondered whether the file had simply been omitted from «git add» or similar, as at that point I'd expect to find its history and how it has changed over time to be important for the git repo (given that changes to it are also listed in the changelog). > If you intend for this to be the case, please drop the Vcs-* headers > from the package in the archive. > This avoids confusion and wasting contributors time. If you still think omitting that file makes sense, then i think what Chris suggests would be better. And with that I'd have defaulted to «apt source» the source package and provide a patch based on that. Thanks, Guillem
