Control: tags -1 + patch

Hi,

On Fri, Jan 24, 2025 at 03:17:28PM +0200, Yavor Doganov wrote:
> make[3]: Entering directory 
> '/build/reproducible-path/cynthiune.app-1.0.0/Bundles/MP3'
> Package mad was not found in the pkg-config search path.
> Perhaps you should add the directory containing `mad.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'mad', required by 'virtual:world', not found
> Package mad was not found in the pkg-config search path.
> Perhaps you should add the directory containing `mad.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'mad', required by 'virtual:world', not found
> Package id3tag was not found in the pkg-config search path.
> Perhaps you should add the directory containing `id3tag.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'id3tag', required by 'virtual:world', not found
> Package id3tag was not found in the pkg-config search path.
> Perhaps you should add the directory containing `id3tag.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'id3tag', required by 'virtual:world', not found
> cd .; \
> /usr/share/GNUstep/Makefiles/mkinstalldirs ./obj
> Package mad was not found in the pkg-config search path.
> Perhaps you should add the directory containing `mad.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'mad', required by 'virtual:world', not found
> Package mad was not found in the pkg-config search path.
> Perhaps you should add the directory containing `mad.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'mad', required by 'virtual:world', not found
> Package id3tag was not found in the pkg-config search path.
> Perhaps you should add the directory containing `id3tag.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'id3tag', required by 'virtual:world', not found
> Package id3tag was not found in the pkg-config search path.
> Perhaps you should add the directory containing `id3tag.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'id3tag', required by 'virtual:world', not found
> Making all for bundle MP3...
> Package mad was not found in the pkg-config search path.
> Perhaps you should add the directory containing `mad.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'mad', required by 'virtual:world', not found
> Package mad was not found in the pkg-config search path.
> Perhaps you should add the directory containing `mad.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'mad', required by 'virtual:world', not found
> Package id3tag was not found in the pkg-config search path.
> Perhaps you should add the directory containing `id3tag.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'id3tag', required by 'virtual:world', not found
> Package id3tag was not found in the pkg-config search path.
> Perhaps you should add the directory containing `id3tag.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'id3tag', required by 'virtual:world', not found
> cd .; \
> /usr/share/GNUstep/Makefiles/mkinstalldirs ./obj/MP3.obj/
> /usr/share/GNUstep/Makefiles/mkinstalldirs MP3.format/.
> Package mad was not found in the pkg-config search path.
> Perhaps you should add the directory containing `mad.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'mad', required by 'virtual:world', not found
> Package mad was not found in the pkg-config search path.
> Perhaps you should add the directory containing `mad.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'mad', required by 'virtual:world', not found
> Package id3tag was not found in the pkg-config search path.
> Perhaps you should add the directory containing `id3tag.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'id3tag', required by 'virtual:world', not found
> Package id3tag was not found in the pkg-config search path.
> Perhaps you should add the directory containing `id3tag.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'id3tag', required by 'virtual:world', not found
> arm-linux-gnueabihf-gcc xing.c -c \
>       -MMD -MP -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 
> -Wdate-time -D_FORTIFY_SOURCE=2 -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 
> -DGNU_GUI_LIBRARY=1 -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -pthread 
> -pthread -fPIC -Wall -DGSWARN -DGSDIAGNOSE -Wno-import -g -O2 -g -O2 
> -Werror=implicit-function-declaration 
> -ffile-prefix-map=/build/reproducible-path/cynthiune.app-1.0.0=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -I../../Frameworks 
> -I../../Frameworks/Cynthiune/Cynthiune.framework/Headers -I../.. -I. 
> -I/usr/include/arm-linux-gnueabihf/GNUstep -I/usr/include \
>        -o obj/MP3.obj/xing.c.o
> arm-linux-gnueabihf-gcc MP3.m -c \
>       -MMD -MP -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 
> -Wdate-time -D_FORTIFY_SOURCE=2 -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 
> -DGNU_GUI_LIBRARY=1 -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 
> -fno-strict-aliasing -fexceptions -fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS 
> -pthread -fPIC -Wall -DGSWARN -DGSDIAGNOSE -Wno-import -g -O2 -g -O2 
> -ffile-prefix-map=/build/reproducible-path/cynthiune.app-1.0.0=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -Wall -Wno-import 
> -fconstant-string-class=NSConstantString -I../../Frameworks 
> -I../../Frameworks/Cynthiune/Cynthiune.framework/Headers -I../.. -I. 
> -I/usr/include/arm-linux-gnueabihf/GNUstep -I/usr/include \
>        -o obj/MP3.obj/MP3.m.o
> arm-linux-gnueabihf-gcc -shared     -Wl,-z,relro -Wl,-z,now 
> -Wl,--no-undefined -Wl,-rpath,/usr/lib/cynthiune.app -pthread -fexceptions 
> -rdynamic -o ./MP3.format/./MP3 ./obj/MP3.obj/xing.c.o ./obj/MP3.obj/MP3.m.o  
>     -L/usr/lib/arm-linux-gnueabihf -L/usr/lib       
> -L../../Frameworks/Cynthiune/Cynthiune.framework/Versions/Current -lCynthiune 
>   -lgnustep-gui    -lgnustep-base    -lobjc   -lm
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `_i_MP3__streamOpen_':
> ./Bundles/MP3/MP3.m:470:(.text+0x2de): undefined reference to 
> `mad_stream_init'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/MP3.m:471:(.text+0x2e6): undefined reference to 
> `mad_frame_init'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/MP3.m:472:(.text+0x2f0): undefined reference to 
> `mad_synth_init'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `_i_MP3__streamClose':
> ./Bundles/MP3/MP3.m:612:(.text+0x622): undefined reference to 
> `mad_frame_finish'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/MP3.m:613:(.text+0x62c): undefined reference to 
> `mad_stream_finish'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `_i_MP3__readNextChunk_withSize_':
> ./Bundles/MP3/MP3.m:304:(.text+0x8e4): undefined reference to 
> `mad_stream_buffer'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `decodeInputBuffer':
> ./Bundles/MP3/MP3.m:306:(.text+0x8ec): undefined reference to 
> `mad_frame_decode'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `_i_MP3__readNextChunk_withSize_':
> ./Bundles/MP3/MP3.m:569:(.text+0x8fa): undefined reference to 
> `mad_synth_frame'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `decodeInputBuffer':
> ./Bundles/MP3/MP3.m:325:(.text+0x930): undefined reference to 
> `mad_stream_errorstr'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/MP3.m:311:(.text+0x972): undefined reference to `id3_tag_query'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/MP3.m:315:(.text+0x97c): undefined reference to 
> `mad_stream_skip'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `_i_MP3___readStreamMetaData':
> ./Bundles/MP3/MP3.m:386:(.text+0xa04): undefined reference to 
> `mad_stream_init'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/MP3.m:387:(.text+0xa10): undefined reference to 
> `mad_frame_init'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/MP3.m:304:(.text+0xa6c): undefined reference to 
> `mad_stream_buffer'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `decodeInputBuffer':
> ./Bundles/MP3/MP3.m:306:(.text+0xa74): undefined reference to 
> `mad_frame_decode'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `_i_MP3___readStreamMetaData':
> ./Bundles/MP3/MP3.m:409:(.text+0xa92): undefined reference to `mad_timer_add'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/MP3.m:428:(.text+0xaf6): undefined reference to 
> `mad_timer_multiply'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `decodeInputBuffer':
> ./Bundles/MP3/MP3.m:325:(.text+0xb22): undefined reference to 
> `mad_stream_errorstr'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `_i_MP3___readStreamMetaData':
> ./Bundles/MP3/MP3.m:439:(.text+0xb40): undefined reference to 
> `mad_timer_count'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/MP3.m:441:(.text+0xb4a): undefined reference to 
> `mad_frame_finish'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/MP3.m:442:(.text+0xb50): undefined reference to 
> `mad_stream_finish'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `decodeInputBuffer':
> ./Bundles/MP3/MP3.m:311:(.text+0xbae): undefined reference to `id3_tag_query'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/MP3.m:315:(.text+0xbb8): undefined reference to 
> `mad_stream_skip'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/MP3.m.o: in function `_i_MP3___readStreamMetaData':
> ./Bundles/MP3/MP3.m:417:(.text+0xbe4): undefined reference to 
> `mad_timer_multiply'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/MP3.m:448:(.text+0xbfc): undefined reference to 
> `mad_timer_zero'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/xing.c.o: in function `xing_parse':
> ./Bundles/MP3/xing.c:42:(.text+0x2a): undefined reference to `mad_bit_read'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/xing.c:45:(.text+0x40): undefined reference to `mad_bit_read'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/xing.c:52:(.text+0x5a): undefined reference to `mad_bit_read'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/xing.c:60:(.text+0x74): undefined reference to `mad_bit_read'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./Bundles/MP3/xing.c:71:(.text+0x96): undefined reference to `mad_bit_read'
> /usr/lib/gcc-cross/arm-linux-gnueabihf/14/../../../../arm-linux-gnueabihf/bin/ld:
>  ./obj/MP3.obj/xing.c.o:./Bundles/MP3/xing.c:80: more undefined references to 
> `mad_bit_read' follow
> collect2: error: ld returned 1 exit status
> make[6]: *** [/usr/share/GNUstep/Makefiles/Instance/bundle.make:205: 
> MP3.format/./MP3] Error 1

I also encountered this bug and didn't find a patch or commit. Hence
adding one. If you already have one, please just use your own. It's a
simple matter of making pkg-config substitutable given that the blocking
bug has been fixed.

Helmut
--- cynthiune.app-1.0.0.orig/Makefile
+++ cynthiune.app-1.0.0/Makefile
@@ -48,8 +48,8 @@
 OBJECTS := $(SOURCES:.m=.o)
 
 VORBIS_LIBS := -lvorbis -lvorbisfile -logg
-MAD_LIBS := $(shell pkg-config mad --libs)
-ID3TAG_LIBS := $(shell pkg-config id3tag --libs)
+MAD_LIBS := $(shell $(PKG_CONFIG) mad --libs)
+ID3TAG_LIBS := $(shell $(PKG_CONFIG) id3tag --libs)
 
 LIBS := -framework AppKit #  -framework AudioUnit -framework AudioToolbox # \
 
@@ -58,6 +58,7 @@
 #	$(ID3TAG_LIBS)
 
 CC := gcc
+PKG_CONFIG ?= pkg-config
 
 CFLAGS := -fconstant-string-class=NSConstantString
 
--- cynthiune.app-1.0.0.orig/Bundles/ALSA/GNUmakefile.preamble
+++ cynthiune.app-1.0.0/Bundles/ALSA/GNUmakefile.preamble
@@ -19,8 +19,8 @@
 # the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
 # Boston, MA 02110-1301, USA.
 
-ALSA_CFLAGS := $(shell pkg-config --cflags alsa)
-ALSA_LIBS := $(shell pkg-config --libs alsa)
+ALSA_CFLAGS := $(shell $(PKG_CONFIG) --cflags alsa)
+ALSA_LIBS := $(shell $(PKG_CONFIG) --libs alsa)
 
 ADDITIONAL_INCLUDE_DIRS += $(ALSA_CFLAGS)
 BUNDLE_LIBS += $(ALSA_LIBS)
--- cynthiune.app-1.0.0.orig/Bundles/AudioFile/GNUmakefile.preamble
+++ cynthiune.app-1.0.0/Bundles/AudioFile/GNUmakefile.preamble
@@ -25,8 +25,8 @@
 # audiofile-config and give priority to it if exists
 #AUDIOFILE_CFLAGS := $(shell audiofile-config --cflags)
 #AUDIOFILE_LIBS := $(shell audiofile-config --libs)
-AUDIOFILE_CFLAGS := $(shell pkg-config --cflags audiofile)
-AUDIOFILE_LIBS := $(shell pkg-config --libs audiofile)
+AUDIOFILE_CFLAGS := $(shell $(PKG_CONFIG) --cflags audiofile)
+AUDIOFILE_LIBS := $(shell $(PKG_CONFIG) --libs audiofile)
 
 ADDITIONAL_INCLUDE_DIRS += -I../.. $(AUDIOFILE_CFLAGS)
 
--- cynthiune.app-1.0.0.orig/Bundles/ID3Tag/GNUmakefile.preamble
+++ cynthiune.app-1.0.0/Bundles/ID3Tag/GNUmakefile.preamble
@@ -25,8 +25,8 @@
 
 BUNDLE_LIBS += $(ID3Tag_LIBS) -L../../Frameworks/Cynthiune/obj
 else
-ID3Tag_CFLAGS := $(shell pkg-config id3tag --cflags)
-ID3Tag_LIBS := $(shell pkg-config id3tag --libs)
+ID3Tag_CFLAGS := $(shell $(PKG_CONFIG) id3tag --cflags)
+ID3Tag_LIBS := $(shell $(PKG_CONFIG) id3tag --libs)
 
 BUNDLE_LIBS += $(ID3Tag_LIBS)
 endif
--- cynthiune.app-1.0.0.orig/Bundles/MP3/GNUmakefile.preamble
+++ cynthiune.app-1.0.0/Bundles/MP3/GNUmakefile.preamble
@@ -33,11 +33,11 @@
 BUNDLE_LIBS += $(MAD_LIBS) $(ID3Tag_LIBS) $(TAGLIB_LIBS) -L../../Frameworks/Cynthiune/obj
 
 else
-MAD_CFLAGS := $(shell pkg-config mad --cflags)
-MAD_LIBS := $(shell pkg-config mad --libs)
+MAD_CFLAGS := $(shell $(PKG_CONFIG) mad --cflags)
+MAD_LIBS := $(shell $(PKG_CONFIG) mad --libs)
 
-ID3Tag_CFLAGS := $(shell pkg-config id3tag --cflags)
-ID3Tag_LIBS := $(shell pkg-config id3tag --libs)
+ID3Tag_CFLAGS := $(shell $(PKG_CONFIG) id3tag --cflags)
+ID3Tag_LIBS := $(shell $(PKG_CONFIG) id3tag --libs)
 
 BUNDLE_LIBS += $(MAD_LIBS) $(ID3Tag_LIBS)
 endif
--- cynthiune.app-1.0.0.orig/Bundles/Taglib/GNUmakefile.preamble
+++ cynthiune.app-1.0.0/Bundles/Taglib/GNUmakefile.preamble
@@ -25,8 +25,8 @@
 
 BUNDLE_LIBS += $(TAGLIB_LIBS) -L../../Frameworks/Cynthiune/obj
 else
-TAGLIB_CFLAGS = $(shell taglib-config --cflags)
-TAGLIB_LIBS = $(shell pkg-config taglib_c --libs)
+TAGLIB_CFLAGS = $(shell $(PKG_CONFIG) taglib_c --cflags)
+TAGLIB_LIBS = $(shell $(PKG_CONFIG) taglib_c --libs)
 
 BUNDLE_LIBS += $(TAGLIB_LIBS)
 endif

Reply via email to