Package: u-boot-asahi
Version: 2025.01-2
Severity: wishlist
Tags: patch
X-Debbugs-Cc: noisyc...@tutanota.com
Dear Maintainer,
Since as early as v2023.04, the Asahi project (Linux on Apple Silicon) has been
carrying patchsets in their downstream u-boot fork [1] to enable multi-install
setups and to load the firmware for the PCI ASMedia XHCI controller that
handles USB ports on some M2 machines. The first of these is especially
important since it enables us developers working on support for Apple Silicon
in Debian to install multiple OSes on our machines for debugging purposes
(without having to install downstream u-boot). The second allows M2 desktop
users to use USB-A keyboards in u-boot. I would like to ask you to please
import these patchsets in u-boot 2025.01. For this purpose, I opened MR!49 on
Salsa [2].
I have included both patchsets in the same MR because they both rely on one
commit (f148278d944, included as PATCH 1/6) to detect the correct EFI system
partition. The original commits corresponding to the patches are as follows
('asahi' branch of [1], rebased onto 2025.01):
[PATCH 1/6] apple: Set up file system firmware loader (f148278d944)
[PATCH 2/6] iopoll: Add readb_poll_sleep_timeout (610aceedd0b)
[PATCH 3/6] usb: xhci-pci: Load ASMedia XHCI controller firmware (93c9572cf7f)
[PATCH 4/6] env: apple: Enable ENV_IS_IN_FAT (948495f4265)
[PATCH 5/6] apple: Nail down the EFI system partition (90d28eb8b59)
[PATCH 6/6] efi_loader: prefer EFI system partition (d0e726db1c2)
As per title, patches 1, 4 and 5 only touch apple code and introduce no new
files. Patches 2 and 3 add new code. In particular, the latter implements the
controller firmware loader in a new source file [3] licensed under GPL-2.0 or
MIT with copyright holders the Asahi Linux Contributors. None of these patches
meaningfully affect existing non-apple code in u-boot.
Patch 6 modifies efi_loader. Since the changes it introduces may affect non-
apple boards, I gated these behind CONFIG_ARCH_APPLE for good measure. This is
the only way the patchset I submitted diverges from dowstream Asahi.
Thank you in advance.
On behalf of the Bananas Team,
NoisyCoil
[1] https://github.com/AsahiLinux/u-boot
[2] https://salsa.debian.org/debian/u-boot/-/merge_requests/49
[3] drivers/usb/host/xhci-pci-asmedia.c
