Control: tags -1 - patch
Control: tags -1 - pending
Control: retitle -1 smart-open: tests fail, S3 possibly broken

That no longer looks like a real solution, as it's not just tests looking at the underlying binary representation that fail: there are also tests (e.g. test_readline, test_s3_iter_lines, test_s3_read/seek_moto) that simply write then read an S3 object in the same file mode and don't get back what they put in.

(Turning off checksum generation by default during actual use probably wouldn't work either, given that this presumably needs to be able to read S3 objects created by other libraries.)

However, if it's as completely broken on S3 with recent botocore as the above implies, then it's odd that neither smart_open upstream nor snakemake upstream seem to have noticed. (snakemake upstream does still use smart_open.) *Possibly* we have a bad combination of boto* and moto versions?

Reply via email to