On Thu, Mar 06, 2025 at 11:47:49AM +0200, Faidon Liambotis wrote: >Control: forwarded -1 https://github.com/dell/libsmbios/pull/149 > >On Wed, Jan 08, 2025 at 08:36:18PM +0100, Lucas Nussbaum wrote: >> > Running ALL PYTHON tests. >> > Traceback (most recent call last): >> > File "/build/reproducible-path/libsmbios-2.4.3/src/pyunit/testAll.py", >> > line 39, in <module> >> > retval = TestLib.runTests( tests ) >> > File "/build/reproducible-path/libsmbios-2.4.3/src/pyunit/TestLib.py", >> > line 29, in runTests >> > temp = unittest.makeSuite( i, testToRun ) >> > ^^^^^^^^^^^^^^^^^^ >> > File "/usr/lib/python3.13/unittest/__init__.py", line 80, in __getattr__ >> > raise AttributeError(f"module {__name__!r} has no attribute {name!r}") >> > AttributeError: module 'unittest' has no attribute 'makeSuite' >> > FAIL src/pyunit/runtests.sh (exit status: 1) > >The fix is trivial, and in fact someone has already made a PR for it >upstream (linked above). > >smbios is, sadly, seemingly abandonware, with the last commit being 5 >years ago. My impression is that the focus has shifted to implementing a >lot of this functionality in Linux itself, with a lot of these bits >being now available through sysfs. However to my knowledge userspace >tooling to leverage it, like e.g. performing the system tag -> express >service code base 36 translation, or map token names to their >descriptions (like smbios-token-ctl through its embedded CSV file) >doesn't exist. > >So it'd be nice if we could at least fix this trivial bug, and get it >back in testing in time for trixie and hope for someone to come up with >a replacement during the forky timeframe. > >WDYT?
That make sense - thanks for looking into this! -- Steve McIntyre, Cambridge, UK. st...@einval.com Mature Sporty Personal More Innovation More Adult A Man in Dandism Powered Midship Specialty
