Bug#1099407: atuin: Crash when working directory is deleted

[Blair Noctis]

On 03/03/2025 17:01, Anders Eurenius Runvald wrote:

Package: atuin
Version: 18.4.0-2
Severity: normal
X-Debbugs-Cc: a...@eurenius.eu

Dear Maintainer,

Running atuin with an absent working directory causes it to crash.

Upstream does not have this behaviour, so the problem should be in one of the
patches.

The immediate offender appears to be `downgrade-config-0.11`, but the code
looks reasonable, so
it seems probable to me that the problem is somewhere in
`config_builder.with_merged`.

Simple reproduction:

     (cd $TMP && mkdir fnord && cd fnord && rmdir ../fnord && atuin doctor)

(I'm somewhat alarmed by how big the changes seem, and in particular commenting
out,
eg. `//.prefix_separator("_")` which would seem to change the interface, but
that's just vibes)

Hi Anders, I assume what you see looks like:

```
Error: could not load client settings

Caused by:
   0: cloud not load config file
   1: No such file or directory (os error 2)

Location:
    crates/atuin-client/src/settings.rs:834:16
```

Thanks for the pointer. I'm now upgrading config and its dependents, this 
should be fixed in a day or two.

I've been annoyed by this for quite some time, and tried to solve it once, but 
somehow concluded that upstream solved this in unreleased commits, and decided 
to wait for next release. After reading your bug report, I compared them again, 
this time 18.4.0 without patching does not exhibit this behavior. So the cause 
should indeed be the patch.

I remember going through docs and confirming `.prefix_separator("_")` was the 
default in the target version to be downgraded to, but it doesn't matter now.

--
Sdrager,
Blair Noctis

OpenPGP_signature.asc
Description: OpenPGP digital signature