Control: reassign -1 src:xserver-xorg-video-geode On Tue, Mar 04, 2025 at 08:01:12AM +0200, Martin-Éric Racine wrote: > ma 3.3.2025 klo 22.04 Niels Thykier (ni...@thykier.net) kirjoitti: > > > > Control: reassign -1 dh-autoreconf > > > > Martin-Éric Racine: > > > Package: debhelper > > > Version: 13.24.1 > > > Severity: important > > > X-Debbugs-Cc: martin-eric.rac...@iki.fi > > > > > > The autoreconf sequence fails to restore files after a build: > > > > > > dpkg-source -b . > > > dpkg-source: info: using source format '3.0 (quilt)' > > > dpkg-source: info: verifying > > > ./xserver-xorg-video-geode_2.18.1.orig.tar.xz.asc > > > dpkg-source: info: building xserver-xorg-video-geode using existing > > > ./xserver-xorg-video-geode_2.18.1.orig.tar.xz > > > dpkg-source: info: building xserver-xorg-video-geode using existing > > > ./xserver-xorg-video-geode_2.18.1.orig.tar.xz.asc > > > dpkg-source: info: local changes detected, the modified files are: > > > xserver-xorg-video-geode/aclocal.m4 > > > xserver-xorg-video-geode/build-aux/config.guess > > > xserver-xorg-video-geode/build-aux/config.sub > > > xserver-xorg-video-geode/build-aux/ltmain.sh > > > xserver-xorg-video-geode/configure > > > xserver-xorg-video-geode/m4/libtool.m4 > > > xserver-xorg-video-geode/m4/ltversion.m4 > > > dpkg-source: error: aborting due to unexpected upstream changes, see > > > /tmp/xserver-xorg-video-geode_2.18.1-1.diff.gQ5RWK > > > > > > Copying the corresponding files from a pristine upstream tarball only > > > works once. They keep on having to be copied back before 'debuild' is run > > > otherwise the above error shows. > > > > > > Martin-Éric > > > > > > [...] > > > > Hi Martin, > > > > I assume this is related to dh-autoreconf to be honest. > > > > Since you see all these files, the package build must have triggered a > > reconf without using dh_autoreconf or without properly changing into > > dh_autoreconf-clean during clean up. > > > > Either way, it is either a bug in xserver-xorg-video-geode or in > > dh-autoreconf and not core debhelper. Reassigning accordingly. > > I explicitly removed the dependency on dh-autoreconf because debhelper > says that since compat 10, it is not needed. This is very much a > debhelper issue. Either debhelper properly restores files or it stops > telling me to remove the Build-Depends on dh-autoreconf.
debhelper depends on dh-autoreconf. In any case, that's for you to figure out where those files are being updated and ensuring that this happens inside the dh_autoreconf call, because frankly, they seem to be updated outside of it. You can look at debian/autoreconf.before and debian/autoreconf.after files after dh_autoreconf ran the autoreconf script to figure out if the files were updated; then they also will be removed. Please note that dh_autoreconf_clean is run by the clean sequence, so building a source package without running clean first is not going to work. -- debian developer - deb.li/jak | jak-linux.org - free software dev ubuntu core developer i speak de, en
