Control: tags -1 moreinfo

On Mon, 6 Jan 2025 21:58:10 +0300
Kirill Rekhov <krekhov....@gmail.com> wrote:

> I am looking for a sponsor for my package "xfce4-docklike-plugin":

hi Kirill,

A new upstream release 0.4.3 came out in December last year and seems
to have been pushed to the upstream branch on salsa, but d/changelog
and the master branch are still at 0.4.2.

An initial review of the current packaging turned up the following
issues:
* copyright: missing copyright holder and license for header at
  src/_gresources.c:1913
* copyright: sources say "gnu.org/licenses/gpl-3.0" in numerous
  places, included license file is GPL-3, yet d/copyright lists
  'Files: *' as gpl-2+.
* copyright: entry for the debian dir lists copyright holder as
  "Debian Xfce Maintainers" but this does not seem to be a team
  package?
* rules: why hardcode 'DEB_BUILD_OPTIONS=notrimdch' in the override of
  dh_installchangelogs?
* rules: the DEB_LDFLAGS_MAINT_APPEND seems to point to an issue in
  the upstream build system failing to detect the X Input lib. Is
  there an upstream bug report for this somewhere, or a way to fix
  the build system to correctly detect that lib?
* lintian hit I: xfce4-docklike-plugin: hardening-no-fortify-functions
  [usr/lib/x86_64-linux-gnu/xfce4/panel/plugins/libdocklike.so] may
  qualify for an override, as plugins often don't directly import any
  libc functions that require hardening (but please do verify that!).
* control: why does this pkg need a build-dep on libsm-dev?

Please enable the CI on the salsa repo, it's a great quality control
tool and time saver for all involved.


Please remove the moreinfo tag (and CC me) once you have an updated
package ready.

Attachment: pgpjEOIcQRJmT.pgp
Description: OpenPGP digital signature

Reply via email to