[sorry for the delay, you didn't CC me, had to get this off the bug page] On Tue, Feb 11, 2025 at 05:37:58AM +0900, Jing Luo wrote: > On 2025-02-10 01:14, наб wrote: > > Overall looks pretty good, but note: > > * You have doubled changelog entries. > > * Accd'g to its description, > > cvsweb-3.0.6+9/debian/patches/0003-483442-fix-perl-510-test-failure.patch > > can be dropped. > > * I disagree with your assessment of Forwarded: not-needed for most > > patches > > (for example, Perl 5.18 is definitely forwardable!). > > * lintian-overriding pedantic and especially pedantic+experimental tags > > makes very little sense (and "I can't decide what to write" is a bad > > override reason). > Thanks very much for the feedback: I admit I got lazy and didn't do well > enough. Now the changelog is fixed, and I re-reviewed all the patches, > forwarded most of them. Great!
> About lintian-overrides: yes I agree with you...but I also get emails from > Phil Wyett (from debian-mentors?) pointing out that "the package is not > ready for sponsorship because of this pedantic tag and this experimental tag > etc." Sponsors have different criteria for sponsorship. I can't see this in the log here or on mentors but if this is how he wrote it then I think this is overzealous on Phil's part, but historically I've found Phil's package analyses insightful and not overly pedantic. > I have sent an email in the past to the mailing list to ask "should I > care about pedantic tags", but I didn't receive any response, until now. Personally I'd say that they're useful to consult occasionally, but to take their recommendations as soft advice, not hard guidance. > > * As for maintainer-manual-page's "don't know how to contact upstream" > > comment: > > * I see Homepage: https://cvsweb.bsd.lv/ -> > > CVSweb was originally developed by members of the FreeBSD project > > and is currently maintained by on BSD.lv. > > Copyright © 2019 Ingo Schwarze, $Date: 2020/10/05 10:40:32 $ > > release notes -> by schwarze > > so it'll be Ingo Schwarze <schwa...@openbsd.org>. > Right, because the email address wasn't written on the webpage, I wasn't > sure if this person Ingo Schwarze is the same person of OpenBSD developer. > But anyway, I sent an email to that address. That's a fair concern, but I'm fairly certain it's the same schwarze as with other bsd.lv projects (like https://cvsweb.bsd.lv/mandoc/). The package looks good to me, I'll forward it to Andreas for sponsoring. Best,
signature.asc
Description: PGP signature
