Xiyue Deng <manp...@gmail.com> writes:

>  
> +# Disable adding sub-directories to `load-path'
> +for DIR in ${el_dir}/*; do [ -d ${DIR} ] && touch ${DIR}/.nosearch; done

I wonder about quoting here. I tend to overquote in shell scripts, but
what if some subdirectory has whitespace in the name?

> +# Remove entries that disable recursive `load-path' handling in 
> sub-directories
> +find ${elc_dir} -name ".nosearch" -exec rm {} \;
> +find ${el_dir} -name ".nosearch" -exec rm {} \;

I think it's better to use find -delete here?


> +
>  if test -e "${elc_dir}"
>  then
>      rmdir --ignore-fail-on-non-empty "${elc_dir}"
> -- 
> 2.39.2

In theory, I think an addon package could ship subdirs.el. In practice
this doesn't seem to happen much (at least I did not find any examples
cases). How should we handle this? Add a check? Ignore the possibility?
Does the emacs packaging documentation have anything to say about this?

d

Reply via email to