Control: tags -1 moreinfo

Hi Dimitris,

On Fri, 03 Jan 2025 22:44:57 +0200 "Dimitris T."
<dimit...@stinpriza.org> wrote:
> Package: runit-services
> Version: 0.8.1
> Severity: normal
> 
> Hey,
> not sure exactly when, but probably sometime in the last 2 versions
> of the package, a new /etc/logrotote.d/aa-rsyslog-runit file was
> introduced.

correct, it's in 0.8.0

>logrotate cron outputs some errors since. messages : 
> 
> "/etc/cron.daily/logrotate:
> error: rsyslog:1 duplicate log entry for /var/log/syslog
> error: rsyslog:1 duplicate log entry for /var/log/mail.log
> error: rsyslog:1 duplicate log entry for /var/log/kern.log
> error: rsyslog:1 duplicate log entry for /var/log/auth.log
> error: rsyslog:1 duplicate log entry for /var/log/user.log
> error: rsyslog:1 duplicate log entry for /var/log/cron.log
> error: found error in file rsyslog, skipping
> run-parts: /etc/cron.daily/logrotate exited with return code 1"
> 
> there is also /etc/logrotate.d/rsyslog with the same logs to rotate,
> provided by rsyslog package. 
> 
> probably related to bug #1079268 and

Yes, that's the bug

> this: 
> https://salsa.debian.org/debian/runit-services/-/commit/6d5b38ff9eb15ee838da078a12a67dc15f9d3bca
>  (?) maybe this check is missing in .postinst?

not really: the idea is that, since there are two logrotate files with
the same entries, the first processed "wins" and the second is skipped.
I agree is a poor solution, but without cooperation on rsyslog side I
don't see many alternatives.

I tested again and besides the error from logrotate, I don't see a real
issue here:

(according to my testing)

* logrotate emits an error but continues to process his files, included
  those that are ordered after /etc/logrotate.d/rsyslog
  (so no log rotation is skipped due to this error, aa-rsyslog-runit
  simply replaces rsyslog)

* cron jobs are not affected by logrotate exit status, so every cron job
  after logrotate is processed (I tested with anacron on daily job)

Could you please look again and see if logrotation and/or cron jobs are
actually skipped due to this error (look at the expected action in the
filesystem)?

Best Regards,
Lorenzo

Reply via email to