Hello Andreas,
On 1/30/25 14:57, Andreas Tille wrote:
> Am Thu, Jan 30, 2025 at 09:47:07AM +0100 schrieb Uwe Kleine-König:
>>> - Bugs filed against the package where one with patch has no
answer from the
>>> maintainer.
>>> - There are QA issues with the package.
>>
>> Another criteria for Package Salvaging (according to [1]) is: "Note that
>> the process is only intended for actively taking over maintainership."
>> Given the big amount of ITS bugs you report, I wonder if this is given.
>
> My intention is to maintain the packages that are obviously orphaned at
> least better than before. We are picking packages that have not seen
> any upload the last five years. I can confirm that packages that were
> taken over by the Salvage team received subsequent uploads if there were
> any visible problems in a way shorter time span.
>
>> If so I wonder further if
>>
>> Maintainer: Package Salvaging Team <team+salv...@tracker.debian.org>
>> Uploaders: Ilyas Gasanov <torso.n...@gmail.com>
>>
>> is really suitable.
>
> It serves the following purpose: The original Maintainer remains
> responsible but every other member of the Package Salvage team can do
> some team upload if necessary.
If I were in the situation that I would want to improve hyphen-ru but
want the original maintainer to keep being responsible, I'd propose an
NMU instead of salvaging because the latter's purpose is (IIUC) to take
away the package from the original maintainer when a new maintainer
has a honest interest in this package. Salvaging for QA like work feels
wrong to me.
>>> I've set up a repository within the salvage-team space[2] to assist you
>>> with this initial setup. If you decide not to accept the ITS, this
>>> repository can easily be moved to another location, such as debian/, or
>>> any place of your choosing. I hope this service helps make the
>>> transition to using a Git repository on Salsa smoother and more
>>> convenient for you.
>>
>> Is "package is not maintained on Salsa" considered a QA issue?
>
> No. But unsupported debhelper compat levels are for instance. Do you
> think it makes sense to specify such QA issues, lintian issues etc.?
I think being more verbose than "There are QA issues with the package"
would be good.
The reason I asked for "maintained on Salsa" is that you mentioned that
as the focus of the Bug of the Day initiative and in my eyes that's not
something that needs fixing. The wiki page states that the criteria to
pick a package includes "No VCS or obviously outdated VCS" and VCS on
github (IMHO) doesn't qualify for that.
Also if you want newcomers to learn from your changes, I'd say e.g.
https://salsa.debian.org/salvage-team/hyphen-ru/-/commit/a42cdf20a5e509a19331cfc7e1a8f0a7b394a0da
would benefit from a more verbose description than "Fix watch file" and
I also don't understand
https://salsa.debian.org/salvage-team/hyphen-ru/-/commit/35b3ddb5e3c786960f265d910d836538b850a9e4
.
Best regards
Uwe
