On Tue, 28 Jan 2025, 20:34 Helmut Grohne, <hel...@subdivi.de> wrote:

> Hi Richard,
>
> Thanks for picking up my report and implementing a more robust solution.
>
> On Tue, Jan 28, 2025 at 12:35:24AM +0000, Richard Lewis wrote:
> > Does the version at
> > https://salsa.debian.org/rpil2/chkrootkit/-/tree/WIP fix this?
>
> I uploaded the commit to debusine.debian.net and it confirms that your
> test now works:
> https://debusine.debian.net/debusine/System/work-request/71379/


great, thank-you - i have learned a few things from this. i will clean up
and do a proper fix.

However:

>
> > (i was slightly wrong in my previous message, and i now think the
> > issue is that the test assumes chkrootkit can see
> > the network manager of the host, and this is apparently not the case
> > in debusine. the new approach is more robust
> > and hopefully makes debusine happy).
>
> This is not really about debusine. It is about autopkgtest in general.
> If you happen to set up an autopkgtest image that happens to not use
> ifupdown/dhclient (which presently is the default), but uses
> systemd-networkd instead, you may locally reproduce the issue.


i tried to confirm this and it does not seem to be the case. I started with
the chkrootkit version that failed in debusine. i did an sbuild and made it
run the rests in lxc --  it passes, but lxc is using dhclient.

 i then added "exit 1" to the test and used
 --shell-fail so i got a shell in lxc

this seems to be broken (
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1073927) but, bizarrely,
if you a suspend (Ctrl-z) and then resume (fg) it works. Then you can do:

apt purge purge isc-dhcp-client
systemctl stop networking.service

cat > /etc/systemd/network/eth.network <<EOF

[Match]
Name=eth*

[Network]
DHCP=ipv4
EOF

systemctl daemon-reload
systemctl start systemd-networkd
networkctl # shows it is working

sed -i 's/^exit 1/####/' debian/tests/test-chkrootkit

debian/tests/test-chkrootkit # still passes.

so i still think there is something different about how debusine presents
the interfaces from the host. Or something else i dont understand

(it might also have to do with /proc, possibly, but i wonder what "ip link
show" in a test running in debusine shows?)

(a shorter testcase would be to just run "chkrootkit sniffer" since that is
what causes the failure)

Reply via email to