Bug#1094470: ucf: env sanitization breaks if OPTIND defined (and dash as /bin/sh)

[Mark Hindley]

Control: tags -1 patch

Lucas,

Thanks for this. I wasn't unaware of #985478.  Since there appears to be no
consensus emerging there, I suppose ucf will just have to work around it, unless
you have an alternative suggestion?

How does this seem?

Mark

commit e04ecdaa9df898470e44acbc1a6fde2dc47d214c
Author: Mark Hindley <m...@hindley.org.uk>
Date:   Tue Jan 28 13:33:49 2025 +0000

    Workaround dash failure to unset OPTIND, see #985478.
    
    Closes: #1094470

diff --git a/ucf b/ucf
index 0c00293..aee84c9 100755
--- a/ucf
+++ b/ucf
@@ -7,6 +7,7 @@ set -e
 while read -r env ; do
     case "$env" in
        '') continue ;;
+       OPTIND) ;; # Dash croaks when unsetting OPTIND. See #985478
        PATH|PWD|TERM) ;;
        LANGUAGE|LANG|LC_*) ;;
        DEB_*|DEBIAN_*|DEBCONF_*) ;;
diff --git a/ucfr b/ucfr
index 49b1115..e927314 100755
--- a/ucfr
+++ b/ucfr
@@ -7,6 +7,7 @@ set -e
 while read -r env ; do
     case "$env" in
        '') continue ;;
+       OPTIND) ;; # Dash croaks when unsetting OPTIND. See #985478
        PATH|PWD|TERM) ;;
        UCF_*) ;;
        *) unset "$env" ;;