Source: vim-command-t
Version: 5.0.5-1
Severity: important
Tags: ftbfs
User: debian-r...@lists.debian.org
Usertags: ruby3.3

Dear Maintainer,

vim-command-t is FTBFSing with ruby3.3 which will become the default
ruby version for Trixie. The transition to make it the default will
start in unstable soon (ruby-defaults/1:3.3~0 is already in experimental
for testing). This is the build log:

https://ruby-builds.debian.net/ruby3.3/21/vim-command-t/vim-command-t_5.0.5-1+rebuild1737418345_amd64-2025-01-21T00:12:26Z.build

I have 2 patches that will make vim-command-t support ruby3.3, those are
attached.

Please, consider importing them and uploading a new version.

TIA!

-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.12.9-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

--
Lucas Kanashiro
From aab4f362f14c1ded963840ee26eee40d7bc902f2 Mon Sep 17 00:00:00 2001
From: Lucas Kanashiro <kanash...@debian.org>
Date: Wed, 22 Jan 2025 18:31:15 -0300
Subject: [PATCH 1/2] d/p/0004-Replace-File.exists-with-File.exist.patch: fix
 FTBFS with ruby3.3

---
 ...-Replace-File.exists-with-File.exist.patch | 22 +++++++++++++++++++
 debian/patches/series                         |  1 +
 2 files changed, 23 insertions(+)
 create mode 100644 debian/patches/0004-Replace-File.exists-with-File.exist.patch

diff --git a/debian/patches/0004-Replace-File.exists-with-File.exist.patch b/debian/patches/0004-Replace-File.exists-with-File.exist.patch
new file mode 100644
index 0000000..1bbb37d
--- /dev/null
+++ b/debian/patches/0004-Replace-File.exists-with-File.exist.patch
@@ -0,0 +1,22 @@
+From: Lucas Kanashiro <kanash...@debian.org>
+Date: Wed, 22 Jan 2025 18:30:20 -0300
+Subject: Replace File.exists? with File.exist?
+
+Forward: no
+---
+ Rakefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Rakefile b/Rakefile
+index ad88d3f..b81b612 100644
+--- a/Rakefile
++++ b/Rakefile
+@@ -70,7 +70,7 @@ end
+ desc 'Clean compiled products'
+ task :clean do
+   Dir.chdir 'ruby/command-t/ext/command-t' do
+-    system 'make clean' if File.exists?('Makefile')
++    system 'make clean' if File.exist?('Makefile')
+     system 'rm -f Makefile'
+   end
+ end
diff --git a/debian/patches/series b/debian/patches/series
index 15ea45a..80555f4 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
 make-verbose.patch
 link-as-needed.patch
 relax-ruby-version-check
+0004-Replace-File.exists-with-File.exist.patch
-- 
2.45.2

From 2ba1c93996896ab54f49e4427109218ea84cdbad Mon Sep 17 00:00:00 2001
From: Lucas Kanashiro <kanash...@debian.org>
Date: Wed, 22 Jan 2025 18:42:31 -0300
Subject: [PATCH 2/2] d/p/0005-Use-Integer-instead-of-Fixnum.patch: fix some
 test failures

---
 .../0005-Use-Integer-instead-of-Fixnum.patch  | 24 +++++++++++++++++++
 debian/patches/series                         |  1 +
 2 files changed, 25 insertions(+)
 create mode 100644 debian/patches/0005-Use-Integer-instead-of-Fixnum.patch

diff --git a/debian/patches/0005-Use-Integer-instead-of-Fixnum.patch b/debian/patches/0005-Use-Integer-instead-of-Fixnum.patch
new file mode 100644
index 0000000..d3f0972
--- /dev/null
+++ b/debian/patches/0005-Use-Integer-instead-of-Fixnum.patch
@@ -0,0 +1,24 @@
+From: Lucas Kanashiro <kanash...@debian.org>
+Date: Wed, 22 Jan 2025 18:41:15 -0300
+Subject: Use Integer instead of Fixnum
+
+In latest ruby version Fixnum was merged into Integer.
+
+Forwarded: no
+---
+ spec/command-t/watchman/utils_spec.rb | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/spec/command-t/watchman/utils_spec.rb b/spec/command-t/watchman/utils_spec.rb
+index 94fd3eb..1de7e82 100644
+--- a/spec/command-t/watchman/utils_spec.rb
++++ b/spec/command-t/watchman/utils_spec.rb
+@@ -14,7 +14,7 @@ describe CommandT::Watchman::Utils do
+ 
+   def little_endian?
+     byte = [0xff00].pack('s')[0]
+-    if byte.is_a?(Fixnum) # ie. Ruby 1.8
++    if byte.is_a?(Integer) # ie. Ruby 1.8
+       byte.zero?
+     elsif byte.is_a?(String) # ie. Ruby >= 1.9
+       byte == "\x00"
diff --git a/debian/patches/series b/debian/patches/series
index 80555f4..34c95f9 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@ make-verbose.patch
 link-as-needed.patch
 relax-ruby-version-check
 0004-Replace-File.exists-with-File.exist.patch
+0005-Use-Integer-instead-of-Fixnum.patch
-- 
2.45.2

Reply via email to