Control: tags -1 - patch
On Wed, 04 Dec 2024 at 21:37:39 +0000, Rebecca N. Palmer wrote:
> Control: tags -1 patch
>
> This (untested) patch may fix this bug
...
> - CaribouKeyboard* _tmp2_ = NULL;
> - CaribouKeyboard* _tmp3_ = NULL;
> + GAsyncInitable* _tmp2_ = NULL;
> + GObject* _tmp3_ = NULL;
This looks like code that was generated by valac. Patching the C code
that was generated by valac is not sustainable: the actual source code
is modules/gtk3/caribou-gtk-module.vala, and if anything is changed to
resolve this bug, it should be that source (or possibly valac).
> but given the more general issues
> around caribou's obsolescence (see other bugs), it might be better to just
> remove it.
I agree. If it was possible to remove it, I think we would already have
done so: it is dead upstream and never progressed beyond the experimental
stage.
Unfortunately, cinnamon (#1041646) and cinnamon-screensaver (no bug yet,
I'll report one now) are blocking caribou's removal.
Please could someone from the cinnamon team either remove those
dependencies, or if caribou is still essential to Cinnamon, take
responsibility for fixing and testing caribou?
Thanks,
smcv
