On Sun, 12 Jan 2025 02:22:07 +0100 (CET) Thorsten Glaser <t...@debian.org> wrote: > On Sat, 26 Oct 2024, Sven Geuer wrote: > > >Feel free to integrate my additions into your repo. You might want to > >test the sysv-init functionality still works. According to my tests > >sysv-init and systemd unit work flawlessly at least when running > >autopkgtest from a Qemu VM. > > I’ve integrated that, but I don’t have a sid system on which to test > this, unfortunately. I did both read *and* diff so I have reasonable > trust that it won’t break anything. Thank you again for your effort, > and if you could test what I uploaded, that would also be great. > > I do have some questions regarding debian/systemd-helper that also > affect debian/rng-tools-debian.service: > > • “/usr/sbin/rngd -p /run/rngd.pid […] && sleep 0.1” > ⇒ should this not be “exec /usr/sbin/rngd -p /run/rngd.pid […]” > instead so the wrapper script is replaced by the actual dæmon? > > • this is Type=forking, should it better be Type=exec (with rngd -f) > or is there anything (use of a wrapper script, pidfiles allowing > tracking the actual dæmon, …) that indicates no?
Yes make it 'exec ...' and change to Type=exec, make it foreground and drop any PID file as they are not necessary at all and just cause confusion. This is best practice nowadays, the forking type and PID file handling are there for legacy services that do not have other options.
