Control: tags -1 +confirmed Alexandre,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Information only Running lintian... N: I: adminerevo: package-contains-documentation-outside-usr-share-doc [usr/share/adminerevo/plugins/drivers/readme.txt] N: N: This package ships a documentation file outside /usr/share/doc N: Documentation files are normally installed inside /usr/share/doc. N: N: If this file doesn't describe the contents or purpose of the directory it N: is in, please consider moving this file to /usr/share/doc/ or maybe even N: removing it. If this file does describe the contents or purpose of the N: directory it is in, please add a lintian override. N: N: Visibility: info N: Show-Always: no N: Check: documentation N: N: Screen: python/egg/metadata N: Advocates: "Scott Kitterman" <deb...@kitterman.com> N: Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for N: Python modules. Those files are not documentation even though N: some of their names carry the .txt file extension. N: N: Python modules can be both public and private. N: N: Read more in N: https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory, N: https://www.python.org/dev/peps/pep-0376/#id16, N: https://www.python.org/dev/peps/pep-0610/, N: https://www.python.org/dev/peps/pep-0639/, N: https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html, N: and Bug#1003913. N: N: I: adminerevo: package-contains-empty-directory [usr/share/adminerevo/designs/hydra/] N: N: This package installs an empty directory. This might be intentional but N: it's normally a mistake. If it is intentional, add a Lintian override. N: N: If a package ships with or installs empty directories, you can remove them N: in debian/rules by calling: N: N: $ find path/to/base/dir -type d -empty -delete N: N: Visibility: info N: Show-Always: no N: Check: files/empty-directories N: N: I: adminerevo: package-contains-empty-directory [usr/share/adminerevo/designs/pepa-linha-dark/] N: N: composer actually not used for building O: adminerevo source: composer-package-without-pkg-php-tools-builddep [composer.json] N: N: The package contains a composer.json file but doesn't build-depend on N: pkg-php-tools. N: N: pkg-php-tools is the recommended tool for building PHP Composer packages. N: For more information, install it and read the included README.Composer. N: N: Visibility: info N: Show-Always: no N: Check: languages/php/pear N: I: Lintian run was successful 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice (build source after successful build [1]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: N/A Summary... I believe 'adminerevo' is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready and appropriate for the distribution. I will leave deeper review to those with experience with such package types - Not my area of expertise. Please try the below on your packages... [1] pbuilder: * Command for 1.: sudo pbuilder build <PACKAGE>.dsc * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild -d unstable <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian --display-info --verbose --fail-on error --info --pedantic --show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon Note: Please report false positives as bug reports against 'licenserecon'. [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method Regards Phil -- Donations... Buy Me A Coffee: https://buymeacoffee.com/kathenasorg -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
