Colin, On Tuesday, January 7, 2025 2:35:41 PM MST Colin King (gmail) wrote: > > I am not able to access it. Did you perhaps set it to be private instead of > > public? > > My bad, I've flipped it to public now.
This looks to be in pretty good shape. I have just a few small things you should look at before I sponsor the upload. 1. Some of the files are dual licensed. These need to be reflected in debian/ copyright. I spot checked a few of these but not all of them. Sometimes lrc has false positives, so don’t worry if these hints are wrong for a few files. $ lrc en: Versions: recon 3.3 check 3.3.9-1 Parsing Source Tree .... Reading d/copyright .... Running licensecheck .... d/copyright | licensecheck BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_process_opt/4xxx_dev0.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_process_opt/4xxx_dev1.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_process_opt/4xxx_dev2.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_process_opt/4xxx_dev3.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_process_opt/4xxx_dev4.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_process_opt/4xxx_dev5.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_process_opt/4xxx_dev6.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_process_opt/4xxx_dev7.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_thread_opt/4xxx_dev0.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_thread_opt/4xxx_dev1.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_thread_opt/4xxx_dev2.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_thread_opt/4xxx_dev3.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_thread_opt/4xxx_dev4.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_thread_opt/4xxx_dev5.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_thread_opt/4xxx_dev6.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/4xxx/ multiple_thread_opt/4xxx_dev7.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/c3xxx/ multiple_process_opt/c3xxx_dev0.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/c3xxx/ multiple_thread_opt/c3xxx_dev0.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/c6xx/ multiple_process_opt/c6xx_dev0.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/c6xx/ multiple_process_opt/c6xx_dev1.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/c6xx/ multiple_process_opt/c6xx_dev2.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/c6xx/ multiple_thread_opt/c6xx_dev0.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/c6xx/ multiple_thread_opt/c6xx_dev1.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/c6xx/ multiple_thread_opt/c6xx_dev2.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/dh895xcc/ multiple_process_opt/dh895xcc_dev0.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 config_file/dh895xcc/ multiple_thread_opt/dh895xcc_dev0.conf BSD-3-Clause | GPL-2 config_file/LICENSE.GPL BSD-3-Clause | BSD-2-clause LICENSE.LZ4 BSD-3-Clause | BSD-2-clause LICENSE.XXHASH BSD-3-Clause | Zlib LICENSE.ZLIB MIT | Expat qatzip.spec.in BSD-3-Clause | BSD-2-clause and/or BSD-3-clause src/xxhash.c BSD-3-Clause | BSD-2-clause and/or BSD-3-clause src/xxhash.h BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ 4xxx/4xxx_dev0.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ 4xxx/4xxx_dev1.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ 4xxx/4xxx_dev2.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ 4xxx/4xxx_dev3.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ 4xxx/4xxx_dev4.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ 4xxx/4xxx_dev5.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ 4xxx/4xxx_dev6.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ 4xxx/4xxx_dev7.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ c3xxx/c3xxx_dev0.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ c6xx/c6xx_dev0.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ c6xx/c6xx_dev1.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ c6xx/c6xx_dev2.conf BSD-3-Clause | BSD-3-clause and/or GPL-2 test/performance_tests/config_file/ dh895xcc/dh895xcc_dev0.conf 2. You should add a debian/upstream/metadata file. There are a number of possible fields. You only need to add the ones that make sense for this project. Here is an example: https://salsa.debian.org/soren/privacybrowser/-/blob/master/debian/upstream/ metadata?ref_type=heads 3. Because you are making the above changes, you should update the date in the changelog and the year for debian/* in debian/copyright. For the changelog, you can update it automatically by running `dch -r`. 4. I see that the upstream ships some tests. You might want to configure autopkgtests to run them. Doing this isn’t necessary for me to sponsor this upload, but it is probably something you want to look at for a future release. 5. You might consider setting up Salsa CI by following the instructions at: https://salsa.debian.org/salsa-ci-team/pipeline This isn’t necessary for me to sponsor your package, but I think you will find it makes your job as a packager easier. Shoot me an email when you have addressed points 1-3. -- Soren Stoutner so...@debian.org
signature.asc
Description: This is a digitally signed message part.
