Control: tags -1 +moreinfo

Matthew,

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

This review is offered to help package submitters to Debian mentors inorder to
improve their packages prior to possible sponsorship into Debian. There is no
obligation on behalf of the submitter to make any alterations based upon
information provided in the review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Information

Running lintian...
N:
I: rumur: file-references-package-build-path [usr/include/rumur/location.hh]
N: 
N:   The listed file or maintainer script appears to reference the build path
N:   used to build the package as specified in the Build-Path field of the
N:   .buildinfo file.
N:   
N:   This is likely to cause the package to be unreproducible, but it may also
N:   indicate that the package will not work correctly outside of the
N:   maintainer's own system.
N:   
N:   Please note that this tag will not appear unless the .buildinfo file
N:   contains a Build-Path field. That field is optional. You may have to set
N:   DEB_BUILD_OPTIONS=buildinfo=+path or use
N:   --buildinfo-option=--always-include-path with dpkg-buildpackage when
N:   building.
N: 
N:   Please refer to https://reproducible-builds.org/,
N:   https://wiki.debian.org/ReproducibleBuilds/BuildinfoFiles, and the
N:   dpkg-genbuildinfo(1) manual page for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: files/contents
N: 
N:
I: rumur: file-references-package-build-path [usr/include/rumur/parser.yy.hh]
N:
N: The file share/README.rst is installed to usr/share/rumur/lib/README.rst,
N: triggering Lintian warnings about documentation installed outside
N: /usr/share/doc. This file qualifies for an exemption because it describes
N: the purpose of the directory it is installed into.
O: rumur: package-contains-documentation-outside-usr-share-doc
[usr/share/rumur/lib/README.rst]
N: 
N:   This package ships a documentation file outside /usr/share/doc
N:   Documentation files are normally installed inside /usr/share/doc.
N:   
N:   If this file doesn't describe the contents or purpose of the directory it
N:   is in, please consider moving this file to /usr/share/doc/ or maybe even
N:   removing it. If this file does describe the contents or purpose of the
N:   directory it is in, please add a lintian override.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: documentation
N: 
N:   Screen: python/egg/metadata
N:     Advocates: "Scott Kitterman" <deb...@kitterman.com>
N:     Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for
N:             Python modules. Those files are not documentation even though
N:             some of their names carry the .txt file extension.
N:             
N:             Python modules can be both public and private.
N:             
N:             Read more in
N:            
https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory,
N:             https://www.python.org/dev/peps/pep-0376/#id16,
N:             https://www.python.org/dev/peps/pep-0610/,
N:             https://www.python.org/dev/peps/pep-0639/,
N:            
https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html,
N:             and Bug#1003913.
N: 

I: Lintian run was successful.

3. Licenses [4]: Information

philwyett@ks-tarkin:~/Development/builder/debian/rumur-2025.01.04$ lrc
en: Versions: recon 3.2  check 3.3.9-1

Parsing Source Tree  ....
Reading d/copyright  ....
  Missing Files: Paragraph for debian/
Running licensecheck ....

No significant differences found

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Issue

 dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building rumur using existing ./rumur_2025.01.04.orig.tar.gz
dpkg-source: warning: file rumur-2025.01.04/.pytest_cache/v/cache/nodeids has
no final newline (either original or modified version)
dpkg-source: warning: file rumur-2025.01.04/.pytest_cache/v/cache/stepwise has
no final newline (either original or modified version)
dpkg-source: info: local changes detected, the modified files are:
 rumur-2025.01.04/.pytest_cache/CACHEDIR.TAG
 rumur-2025.01.04/.pytest_cache/README.md
 rumur-2025.01.04/.pytest_cache/v/cache/nodeids
 rumur-2025.01.04/.pytest_cache/v/cache/stepwise
dpkg-source: hint: make sure the version in debian/changelog matches the
unpacked source tree
dpkg-source: hint: you can integrate the local changes with dpkg-source --
commit
dpkg-source: error: aborting due to unexpected upstream changes, see
/tmp/rumur_2025.01.04-1.diff.oYw7vs
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
I: copying local configuration
E: Failed autobuilding of package

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Not performed at this time

8. Upgrade [Over previous installs if any]: Not performed at this time

Additional...

A. autopkgtest

Rumur version v2025.01.04-1
autopkgtest [16:24:53]: test rumur-version: -----------------------]
autopkgtest [16:24:53]: test rumur-version:  - - - - - - - - - - results - - -
- - - - - - -
rumur-version        PASS
autopkgtest [16:24:53]: @@@@@@@@@@@@@@@@@@@@ summary
librumur-api         FAIL non-zero exit status 1
murphi2c-header      PASS
murphi2c-source      PASS
murphi2c-version     PASS
murphi2murphi-basic  PASS
murphi2murphi-version PASS
murphi2xml-model     PASS
murphi2xml-version   PASS
rumur-model          PASS
rumur-run-model      PASS
rumur-version        PASS

E: Autopkgtest run failed.

Off topic...

Maybe you should consider application to become a Debian Maintainer.

https://wiki.debian.org/DebianMaintainer

Summary...

I believe rumur is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

Please try the below on your packages...

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'.

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
  
Regards

Phil

-- 
Donations...

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

--

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg

Threads: https://www.threads.net/@kathenasorg

--

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to