Control: tags -1 patch
On Sat, 7 Dec 2024 22:13:59 +0100 Niels Thykier <ni...@thykier.net> wrote:
Source: z8530-utils2
Version: 3.0-1-11
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue
Dear maintainer,
During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
z8530-utils2 failed to rebuild.
Log Summary:
-------------------------------------------------------------------------------
[...]
Hi
Please see attached as a patch.
I intend to NMU to make progress on the MBF if I do not hear from you on
this. It would help me if you either uploaded this soon or approved the
NMU (enabling me to skip the delay). Thanks in advance.
This package can probably come truly rootless if the upstream makefile
could be convinced to not pass `-o root -g root` to `install`. A common
trick here is to use `-o $(USER) -g $(GROUP)` and then have the Debian
package substitute USER/GROUP with `id -u`/`id -g` (which is a noop but
allowed) and then rely on `dh_fixperms` + `dh_builddeb` to build the
package with the correct ownership. However, it is was not a minimal
patch, so I skipped that for the NMU.
Best regards,
Niels
diff -Nru z8530-utils2-3.0-1/debian/changelog
z8530-utils2-3.0-1/debian/changelog
--- z8530-utils2-3.0-1/debian/changelog 2024-02-28 09:49:07.000000000 +0100
+++ z8530-utils2-3.0-1/debian/changelog 2025-01-01 17:28:36.000000000 +0100
@@ -1,3 +1,11 @@
+z8530-utils2 (3.0-1-11.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Make requirement for root when building the package explicit.
+ (Closes: #1089486)
+
+ -- Niels Thykier <ni...@thykier.net> Wed, 01 Jan 2025 16:28:36 +0000
+
z8530-utils2 (3.0-1-11) unstable; urgency=low
* Team upload.
diff -Nru z8530-utils2-3.0-1/debian/control z8530-utils2-3.0-1/debian/control
--- z8530-utils2-3.0-1/debian/control 2024-02-28 09:48:06.000000000 +0100
+++ z8530-utils2-3.0-1/debian/control 2025-01-01 17:28:30.000000000 +0100
@@ -3,6 +3,7 @@
Priority: optional
Maintainer: Debian Hamradio Maintainers <debian-h...@lists.debian.org>
Uploaders: Jaime Robles <ja...@debian.org>, Patrick Ouellette
<poue...@debian.org>
+Rules-Requires-Root: binary-targets
Standards-Version: 4.5.0
Build-Depends: debhelper-compat (= 12)
Vcs-Browser: https://salsa.debian.org/debian-hamradio-team/z8530-utils2
