Bug#1091851: git-buildpackage 0.9.36 fails with python 3.8

[Guido Günther]

Hi,
On Wed, Jan 01, 2025 at 02:32:46PM +0100, أحمد المحمودي (Ahmed El-Mahmoudy) 
wrote:
> Package: git-buildpackage
> Version: 0.9.36
> Severity: normal
> 
> Dear Maintainer,
> 
> 
>   I intended to file a report on salsa, but I didn't find an issue 
>   tracker there.
>   I installed gbp using pip3 on a Ubuntu focal system, it worked fine 
>   till 0.9.35. But when I upgraded yo 0.9.36, and attempted a gbp clone, 
>   I got this error:
> 
> gbp clone g...@salsa.debian.org:aelmahmoudy/libxml-5-0.git
> Traceback (most recent call last):
>   File "/home/HOMEDIR/.local/bin/gbp", line 8, in <module>
>     sys.exit(supercommand())
>   File 
> "/home/HOMEDIR/.local/lib/python3.8/site-packages/gbp/scripts/supercommand.py",
>  line 137, in supercommand
>     module = import_command(cmd)
>   File 
> "/home/HOMEDIR/.local/lib/python3.8/site-packages/gbp/scripts/supercommand.py",
>  line 71, in import_command
>     return __import__('gbp.scripts.%s' % modulename, fromlist='main', level=0)
>   File 
> "/home/HOMEDIR/.local/lib/python3.8/site-packages/gbp/scripts/clone.py", line 
> 30, in <module>
>     from gbp.scripts.common import ExitCodes
>   File 
> "/home/HOMEDIR/.local/lib/python3.8/site-packages/gbp/scripts/common/__init__.py",
>  line 25, in <module>
>     from gbp.deb.upstreamsource import DebianAdditionalTarball
>   File 
> "/home/HOMEDIR/.local/lib/python3.8/site-packages/gbp/deb/upstreamsource.py", 
> line 73
>     type DebianUpstreamTarballList = list[DebianUpstreamSource | 
> DebianAdditionalTarball]
>          ^
> SyntaxError: invalid syntax

That's from the type annotations. I don't think we test on anything
older than 3.11.

If there's anything to make this compatible with 3.8 without cluttering
the codebase I'm happy to do that. Otherwise I'll bump the minimum
Python version with the next upload:

   https://salsa.debian.org/agx/git-buildpackage/-/merge_requests/34

(for local use reverting the type annotations should do the trick)

Cheers,
 -- Guido

signature.asc
Description: PGP signature