Bug#1089428: sdcc: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 21:35:14 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: sdcc
Version: 4.4.0+dfsg-2
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
sdcc failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

Hi

Please see attached as a patch.



Best regards,
Niels


diff -Nru sdcc-4.4.0+dfsg/debian/changelog sdcc-4.4.0+dfsg/debian/changelog
--- sdcc-4.4.0+dfsg/debian/changelog    2024-03-20 23:01:35.000000000 +0100
+++ sdcc-4.4.0+dfsg/debian/changelog    2024-12-31 11:45:15.000000000 +0100
@@ -1,3 +1,10 @@
+sdcc (4.4.0+dfsg-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for root when building the package.
+
+ -- Niels Thykier <ni...@thykier.net>  Tue, 31 Dec 2024 10:45:15 +0000
+
 sdcc (4.4.0+dfsg-2) unstable; urgency=medium
 
   * Include libexec/…/cc1 (Closes: #1067263)
diff -Nru sdcc-4.4.0+dfsg/debian/control sdcc-4.4.0+dfsg/debian/control
--- sdcc-4.4.0+dfsg/debian/control      2024-03-18 18:57:55.000000000 +0100
+++ sdcc-4.4.0+dfsg/debian/control      2024-12-31 11:45:12.000000000 +0100
@@ -24,6 +24,7 @@
                      texlive-latex-extra,
                      gsfonts,
                      librsvg2-bin
+Rules-Requires-Root: no
 Standards-Version: 4.4.1
 Homepage: http://sdcc.sourceforge.net
 Vcs-Git: https://salsa.debian.org/electronics-team/sdcc.git
diff -Nru sdcc-4.4.0+dfsg/debian/rules sdcc-4.4.0+dfsg/debian/rules
--- sdcc-4.4.0+dfsg/debian/rules        2024-03-18 23:03:08.000000000 +0100
+++ sdcc-4.4.0+dfsg/debian/rules        2024-12-31 11:44:27.000000000 +0100
@@ -96,7 +96,7 @@
        dh_prep
        $(MAKE) install prefix=$(CURDIR)/debian/tmp/usr
        mkdir -p debian/tmp/usr/share/doc/sdcc-doc
-       install -o root -g root -m 644 doc/sdccman.pdf 
debian/tmp/usr/share/doc/sdcc-doc
+       install -m 644 doc/sdccman.pdf debian/tmp/usr/share/doc/sdcc-doc
        mv debian/tmp/usr/share/doc/sdcc/* debian/tmp/usr/share/doc/sdcc-doc/
        rm -f debian/tmp/usr/share/doc/sdcc-doc/z80/combined_i186_z80_design.tex
        rm -f debian/tmp/usr/share/doc/sdcc-doc/z80/Makefile
@@ -146,8 +146,8 @@
        rm -rf `find $(CURDIR)/debian/tmp -type d -name .deps`
        # Add some scripts
        mkdir -p debian/tmp/usr/share/sdcc/scripts
-       install -o root -g root -m 755  support/scripts/*.pl 
debian/tmp/usr/share/sdcc/scripts
-       install -o root -g root -m 755  support/scripts/*.py 
debian/tmp/usr/share/sdcc/scripts
+       install -m 755  support/scripts/*.pl debian/tmp/usr/share/sdcc/scripts
+       install -m 755  support/scripts/*.py debian/tmp/usr/share/sdcc/scripts
        # Remove an unnecessary script 
        rm -f debian/tmp/usr/share/sdcc/scripts/gen_known_bugs.pl
        dh_install -a --sourcedir=debian/tmp

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

OpenPGP_signature.asc
Description: OpenPGP digital signature