Bug#1089368: libpam-ccreds: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 20:35:15 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: libpam-ccreds
Version: 10-10
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
libpam-ccreds failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

Hi

Please see attached as a patch.



Best regards,
Niels


diff -Nru libpam-ccreds-10/debian/changelog libpam-ccreds-10/debian/changelog
--- libpam-ccreds-10/debian/changelog   2024-06-21 07:36:38.000000000 +0200
+++ libpam-ccreds-10/debian/changelog   2024-12-31 11:30:13.000000000 +0100
@@ -1,3 +1,15 @@
+libpam-ccreds (10-10.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Make requirement for root when building the package explicit.
+    (Closes: #1089368)
+  * Reorder some logic in debian/rules to make it easier to make
+    the package rootless down the line. With these changes, it would
+    just need a patch to the upstream makefile and
+    `Rules-Requires-Root` set to `no`.
+
+ -- Niels Thykier <ni...@thykier.net>  Tue, 31 Dec 2024 10:30:13 +0000
+
 libpam-ccreds (10-10) unstable; urgency=medium
 
   * [cb3a76c] d/gbp.conf: Switch to more modern layout
diff -Nru libpam-ccreds-10/debian/control libpam-ccreds-10/debian/control
--- libpam-ccreds-10/debian/control     2024-06-21 07:34:34.000000000 +0200
+++ libpam-ccreds-10/debian/control     2024-12-31 11:30:13.000000000 +0100
@@ -7,6 +7,7 @@
  libdb-dev,
  libgcrypt20-dev,
  libpam0g-dev,
+Rules-Requires-Root: binary-targets
 Standards-Version: 4.6.2
 Homepage: https://github.com/PADL/pam_ccreds
 Vcs-Browser: https://salsa.debian.org/agx/libpam-ccreds
diff -Nru libpam-ccreds-10/debian/rules libpam-ccreds-10/debian/rules
--- libpam-ccreds-10/debian/rules       2024-06-20 08:17:42.000000000 +0200
+++ libpam-ccreds-10/debian/rules       2024-12-31 11:29:34.000000000 +0100
@@ -15,8 +15,6 @@
 
 override_dh_auto_install:
        dh_auto_install
-       chown root:root debian/libpam-ccreds/usr/sbin/ccreds_chkpwd
-       chmod 4755 debian/libpam-ccreds/usr/sbin/ccreds_chkpwd
 
        mkdir -p debian/libpam-ccreds/usr/share/pam-configs
        install -m 0644 debian/libpam-ccreds.pam-auth-update.ccreds-save \
@@ -24,6 +22,6 @@
        install -m 0644 debian/libpam-ccreds.pam-auth-update.ccreds-check \
                debian/libpam-ccreds/usr/share/pam-configs/ccreds-check
 
-override_dh_fixperms:
-       dh_fixperms -X/usr/sbin/ccreds_chkpwd
+execute_after_dh_fixperms:
+       chmod 4755 debian/libpam-ccreds/usr/sbin/ccreds_chkpwd
 

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

OpenPGP_signature.asc
Description: OpenPGP digital signature