Bug#1089450: tcptraceroute: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 21:52:47 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: tcptraceroute
Version: 1.5beta7+debian-4.1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
tcptraceroute failed to rebuild.

[...]

Hi,

Please see attached as a patch.



Note to self: Maintainer is on lowNMU (no delay is ok).

Best regards,
Niels


diff -Nru tcptraceroute-1.5beta7+debian/debian/changelog 
tcptraceroute-1.5beta7+debian/debian/changelog
--- tcptraceroute-1.5beta7+debian/debian/changelog      2019-07-09 
18:07:47.000000000 +0200
+++ tcptraceroute-1.5beta7+debian/debian/changelog      2024-12-31 
08:59:35.000000000 +0100
@@ -1,3 +1,11 @@
+tcptraceroute (1.5beta7+debian-4.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for root when building the package.
+    (Closes: #1089450)
+
+ -- Niels Thykier <ni...@thykier.net>  Tue, 31 Dec 2024 07:59:35 +0000
+
 tcptraceroute (1.5beta7+debian-4.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru tcptraceroute-1.5beta7+debian/debian/control 
tcptraceroute-1.5beta7+debian/debian/control
--- tcptraceroute-1.5beta7+debian/debian/control        2019-07-09 
18:07:45.000000000 +0200
+++ tcptraceroute-1.5beta7+debian/debian/control        2024-12-31 
08:56:01.000000000 +0100
@@ -6,6 +6,7 @@
  debhelper-compat (= 12),
  libnet1-dev,
  libpcap0.8-dev,
+Rules-Requires-Root: no
 Standards-Version: 4.4.0
 Homepage: https://github.com/mct/tcptraceroute
 Vcs-Git: https://salsa.debian.org/debian/tcptraceroute.git
diff -Nru tcptraceroute-1.5beta7+debian/debian/rules 
tcptraceroute-1.5beta7+debian/debian/rules
--- tcptraceroute-1.5beta7+debian/debian/rules  2019-05-28 22:45:28.000000000 
+0200
+++ tcptraceroute-1.5beta7+debian/debian/rules  2024-12-31 08:56:26.000000000 
+0100
@@ -19,13 +19,10 @@
 override_dh_missing:
        dh_missing --fail-missing
 
-override_dh_auto_install:
-       dh_auto_install
+execute_after_dh_auto_install:
        mv debian/tcptraceroute/usr/bin/tcptraceroute 
debian/tcptraceroute/usr/bin/tcptraceroute.mt
        mv debian/tcptraceroute/usr/share/man/man1/tcptraceroute.1 
debian/tcptraceroute/usr/share/man/man1/tcptraceroute.mt.1
-       chmod 4755 debian/tcptraceroute/usr/bin/tcptraceroute.mt
-       chown root:root debian/tcptraceroute/usr/bin/tcptraceroute.mt
        rm -rf debian/tcptraceroute/usr/share/doc/tcptraceroute
 
-override_dh_fixperms:
-       dh_fixperms -Xusr/bin/tcptraceroute.mt
+execute_after_dh_fixperms:
+       chmod 4755 debian/tcptraceroute/usr/bin/tcptraceroute.mt

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

OpenPGP_signature.asc
Description: OpenPGP digital signature