Bug#1089462: vm: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 21:59:47 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: vm
Version: 8.2.0b-11
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
vm failed to rebuild.

[...]

Please see attached as a patch.



Best regards,
Niels


diff -u vm-8.2.0b/debian/changelog vm-8.2.0b/debian/changelog
--- vm-8.2.0b/debian/changelog
+++ vm-8.2.0b/debian/changelog
@@ -1,3 +1,11 @@
+vm (8.2.0b-11.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for using root when builing the package.
+    (Closes: #1089462)
+
+ -- Niels Thykier <ni...@thykier.net>  Mon, 30 Dec 2024 18:40:37 +0000
+
 vm (8.2.0b-11) unstable; urgency=medium
 
   * Expand byte-compilation workaround to new variable name.
diff -u vm-8.2.0b/debian/control vm-8.2.0b/debian/control
--- vm-8.2.0b/debian/control
+++ vm-8.2.0b/debian/control
@@ -3,6 +3,7 @@
 Homepage: https://launchpad.net/vm
 Priority: optional
 Maintainer: Ian Jackson <ijack...@chiark.greenend.org.uk>
+Rules-Requires-Root: no
 Standards-Version: 3.9.6
 Build-Depends: debhelper (>= 9.0.0), autotools-dev
 Build-Depends-Indep: autoconf, emacs-nox | emacs | emacs25-nox | emacs25 | 
emacs24,
diff -u vm-8.2.0b/debian/rules vm-8.2.0b/debian/rules
--- vm-8.2.0b/debian/rules
+++ vm-8.2.0b/debian/rules
@@ -26,10 +26,10 @@
 ifeq (,$(filter nostrip,$(DEB_BUILD_OPTIONS)))
     INSTALL_PROGRAM += -s
 endif
-install_file    = $(INSTALL) -p    -o root -g root  -m  644
-install_program = $(INSTALL) -p    -o root -g root  -m  755
-install_script  = $(INSTALL) -p    -o root -g root  -m  755
-make_directory  = $(INSTALL) -p -d -o root -g root  -m  755
+install_file    = $(INSTALL) -p    -m  644
+install_program = $(INSTALL) -p    -m  755
+install_script  = $(INSTALL) -p    -m  755
+make_directory  = $(INSTALL) -p -d -m  755
 
 
 PREFIX     = /usr
@@ -73,9 +73,9 @@
        test ! -d  $(TMPTOP)/$(PREFIX)/share/$(package)/pixmaps || \
           mv $(TMPTOP)/$(PREFIX)/share/$(package)/pixmaps \
              $(TMPTOP)$(P_PIXMAPDIR)
-       test ! -f $(TMPTOP)/usr/share/$(package)/COPYING || rm 
$(TMPTOP)/usr/share/$(package)/COPYING
-       test ! -f $(DOCDIR)/CHANGES || rm $(DOCDIR)/CHANGES
-       test ! -f $(DOCDIR)/COPYING || rm $(DOCDIR)/COPYING
+       test ! -f $(TMPTOP)/usr/share/$(package)/COPYING || rm -f 
$(TMPTOP)/usr/share/$(package)/COPYING
+       test ! -f $(DOCDIR)/CHANGES || rm -f $(DOCDIR)/CHANGES
+       test ! -f $(DOCDIR)/COPYING || rm -f $(DOCDIR)/COPYING
        mv $(TMPTOP)$(P_LISPDIR){,.in}
 
 override_dh_fixperms:

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

OpenPGP_signature.asc
Description: OpenPGP digital signature