Control: reassign -1 module-assistant Control: affects -1 v4l2loopback Control: tag -1 + patch
On Mon, 23 Dec 2024 03:05:47 +0100, Santiago Vila <sanv...@debian.org> wrote: > After make 4.4.1-1 has been uploaded for unstable, the > autopkgtests for this package fail: > > https://ci.debian.net/packages/v/v4l2loopback/testing/amd64/55629088/ > > This may be because of changes in $(shell) environment handling: environment > variables exported from Makefiles are now made available to commands invoked > using $(shell), which can cause issues with recursive definitions in > particular. > > See https://salsa.debian.org/debian/make/-/blob/master/debian/NEWS for a > complete list of backward-incompatible changes since Make 4.3. It turns out that this is an issue in module-assistant, caused by the change in behaviour of the print-directory option. The attached patch fixes this; it’s also available as https://salsa.debian.org/debian/module-assistant/-/merge_requests/1 Regards, Stephen
commit c98d80f6969299b4651c66b8dafdc44c68042ae4 Author: Stephen Kitt <sk...@debian.org> Date: Mon Dec 30 10:29:54 2024 +0100 Disable printing directories for show-CC Recent changes in Make mean that the show-CC snippet ends up including directory change messages, which are included in the stored value for CC and result in a failure to find the compiler. Explicitly disabling these messages fixes this. Closes: #1091181. Signed-off-by: Stephen Kitt <sk...@debian.org> diff --git a/modass/include/generic.make b/modass/include/generic.make index e085fd5..1d703b6 100644 --- a/modass/include/generic.make +++ b/modass/include/generic.make @@ -42,7 +42,7 @@ endif # See if we can work out the compiler used ifeq ($(origin CC),default) ifneq (,$(wildcard $(KSRC)/.kernelvariables)) -CC = $(shell /bin/echo -e "show-%:\n\t@echo \$$(\$$*)\ninclude $(KSRC)/.kernelvariables" | $(MAKE) -f - show-CC) +CC = $(shell /bin/echo -e "show-%:\n\t@echo \$$(\$$*)\ninclude $(KSRC)/.kernelvariables" | $(MAKE) --no-print-directory -f - show-CC) else ifneq "$(wildcard $(KSRC)/include/linux/compile.h)" "" CC = gcc-$(shell grep LINUX_COMPILER $(KSRC)/include/linux/compile.h | sed 's/.* \([0-9]\+\.[0-9]\+\).*/\1/') @@ -263,7 +263,7 @@ echo-deb: echo-debfile: @echo $(DEB_DESTDIR)/$(PKGNAME)_$(CVERSION)_$(PKGARCH).deb - + # That is a matter of taste (of the maintainer) # Targets that kernel-package uses. #kdist_configure: configure-stamp
pgpSyE_SBNHaM.pgp
Description: OpenPGP digital signature