Andrea Pappacoda:
Hi Niels for some reason I didn't receive your initial reply to my bug report.On Sun Dec 29, 2024 at 2:56 PM CET, Niels Thykier wrote:I had a look at it and I am leaning towards https://salsa.debian.org/ debian/debhelper/-/merge_requests/131 as a possible solution.The idea here being that you would be able to use: override_dh_auto_install: $(DH_OVERRIDDEN_COMMAND) -- <extra params>with $(DH_OVERRIDDEN_COMMAND) preserving the --destdir parameter from the add-on. With the plain `dh_auto_install` (instead of `$(DH_OVERRIDDEN_COMMAND)`) for the case where you need to override the implicit options too.I like this! I always thought that repeating the overridden dh command was a bit redundant.
Thanks. :)
Still, "DH_OVERRIDDEN_COMMAND" looks a bit long. It's not a big deal at all, but we can find something prettier.Wouldn't it be possible to do something like: override_dh_auto_install: dh_overridden -- <extra params> where dh_overridden is a binary which does the correct thing?
The `dh_overridden` trick has its merits like it has a very clean failure mode and is not subject to makefile conditionals and empty target rules.
On the other hand, the $(DH_OVERRIDDEN_COMMAND) trick causes `make` to output the full command being run, so the log output is correct. This style would have `make` output `dh_overridden`, which would then have to print it. In that sense, $(DH_OVERRIDDEN_COMMAND) looks "nicer" than `dh_overridden`.
Additionally, I would have to deal with command line option merging (`dh_overridden` would have its own command line parsing). Notably, it suggests that you might be able to override the package selection parameters like -a/-i vs. -p/-N. However, that would be non-trivial to do and I do not want to have that discussion once a year (if my worries turn out to be true).
I guess that a make-based solution like the one you proposed is simpler, but since this is probably something that people will start to use extensively in rules files I'd rather have something which looks nice :)
Currently, one of them looks nice in the makefile and the other looks nice in the log file. I guess that is... something. :D
In any case, thanks for working on a fix!
You are welcome, Best regards, Niels
OpenPGP_signature.asc
Description: OpenPGP digital signature
