Hi,

On Mon, Jun 12, 2006, Daniel Kobras wrote:
> > +ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
> > +        INSTALL_PROGRAM += -s
> > +endif
> This looks superfluous to me as dh_strip should already handle nostrip
> internally.

 Probably.  I don't know if this covers some interesting cases or not.

 I grepped though pkg-gnome **/rules to see what interesting noopt /
 nostrip snippets I could find.  This seems to strip files at install
 time instead of relying on dh_strip.

> > -   ./configure --prefix=/usr --mandir=\$${prefix}/share/man 
> > --infodir=\$${prefix}/share/info
> > +   env CFLAGS="$(CFLAGS)" ./configure --prefix=/usr 
> > --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info
> Why are you using env here? CFLAGS="$(CFLAGS)" ./configure ... ought to
> suffice from what I can tell.

 Same remark, I saw some packages using export CFLAGS, other passing
 CFLAGS as a configure arg, most using CFLAGS=... ./configure, and one
 using env.  I don't think it adds anything.

 Do as you please with these.

   Bye,
-- 
Loïc Minier <[EMAIL PROTECTED]>

Reply via email to