Bug#1089434: sidplay-libs: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 21:38:41 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: sidplay-libs
Version: 2.1.1-15
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
sidplay-libs failed to rebuild.

[...]

Please see attached as a way to solve this problem.

Best regards,
Niels



diff -Nru sidplay-libs-2.1.1/debian/changelog 
sidplay-libs-2.1.1/debian/changelog
--- sidplay-libs-2.1.1/debian/changelog 2016-09-19 19:29:28.000000000 +0200
+++ sidplay-libs-2.1.1/debian/changelog 2024-12-29 11:57:03.000000000 +0100
@@ -1,3 +1,11 @@
+sidplay-libs (2.1.1-15.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove the need for root when building the package.
+    (Closes: #1089434)
+
+ -- Niels Thykier <ni...@thykier.net>  Sun, 29 Dec 2024 10:57:03 +0000
+
 sidplay-libs (2.1.1-15) unstable; urgency=low
 
   * Fix FTBFS due to GCC 6 narrowing conversions (closes: #837378).
diff -Nru sidplay-libs-2.1.1/debian/control sidplay-libs-2.1.1/debian/control
--- sidplay-libs-2.1.1/debian/control   2016-09-19 19:29:28.000000000 +0200
+++ sidplay-libs-2.1.1/debian/control   2024-12-29 11:56:25.000000000 +0100
@@ -3,6 +3,7 @@
 Priority: optional
 Maintainer: Laszlo Boszormenyi (GCS) <g...@debian.org>
 Build-Depends: debhelper (>= 9), autoconf, automake, libtool
+Rules-Requires-Root: no
 Standards-Version: 3.9.8
 
 Package: libsidplay2-dev
diff -Nru sidplay-libs-2.1.1/debian/rules sidplay-libs-2.1.1/debian/rules
--- sidplay-libs-2.1.1/debian/rules     2016-09-19 19:29:28.000000000 +0200
+++ sidplay-libs-2.1.1/debian/rules     2024-12-29 11:56:16.000000000 +0100
@@ -98,14 +98,14 @@
        dh_testroot
        dh_movefiles
 
-       install -d -o root -g root -m 755 
debian/libsidplay2/usr/share/doc/libsidplay2
-       install -d -o root -g root -m 755 
debian/libsidplay2/usr/share/lintian/overrides
+       install -d -m 755 debian/libsidplay2/usr/share/doc/libsidplay2
+       install -d -m 755 debian/libsidplay2/usr/share/lintian/overrides
        cp $(CURDIR)/debian/libsidplay2.lintian  
$(CURDIR)/debian/libsidplay2/usr/share/lintian/overrides/libsidplay2
-       install -d -o root -g root -m 755 debian/libsidplay-dev/usr/share/doc
-       install -d -o root -g root -m 755 
debian/libsidutils0/usr/share/doc/libsidutils0
-       install -d -o root -g root -m 755 debian/libsidutils-dev/usr/share/doc
-       install -d -o root -g root -m 755 
debian/libresid-builder0c2a/usr/share/doc/libresid-builder0c2a
-       install -d -o root -g root -m 755 
debian/libresid-builder-dev/usr/share/doc
+       install -d -m 755 debian/libsidplay-dev/usr/share/doc
+       install -d -m 755 debian/libsidutils0/usr/share/doc/libsidutils0
+       install -d -m 755 debian/libsidutils-dev/usr/share/doc
+       install -d -m 755 
debian/libresid-builder0c2a/usr/share/doc/libresid-builder0c2a
+       install -d -m 755 debian/libresid-builder-dev/usr/share/doc
 
        dh_installdocs
        dh_installexamples
@@ -114,8 +114,8 @@
        dh_installman
        dh_installinfo
 
-       install -o root -g root -m 644 libsidplay/ChangeLog 
debian/libsidplay2/usr/share/doc/libsidplay2/changelog
-       install -o root -g root -m 644 libsidutils/ChangeLog 
debian/libsidutils0/usr/share/doc/libsidutils0/changelog
+       install -m 644 libsidplay/ChangeLog 
debian/libsidplay2/usr/share/doc/libsidplay2/changelog
+       install -m 644 libsidutils/ChangeLog 
debian/libsidutils0/usr/share/doc/libsidutils0/changelog
        dh_installchangelogs
        dh_link
        dh_strip

OpenPGP_signature.asc
Description: OpenPGP digital signature