Bug#1089433: shim-helpers-arm64-signed: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 21:38:02 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: shim-helpers-arm64-signed
Version: 1+15.8+1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
shim-helpers-arm64-signed failed to rebuild.

Log Summary:
[...]

Hi,

Please review attached as an example of how to fix this problem.

Note: Untested, since I was doing my testing on amd64.

Best regards,
Niels


diff -Nru shim-helpers-arm64-signed-1+15.8+1/debian/changelog 
shim-helpers-arm64-signed-1+15.8+1+nmu1/debian/changelog
--- shim-helpers-arm64-signed-1+15.8+1/debian/changelog 2024-05-05 
00:29:52.000000000 +0200
+++ shim-helpers-arm64-signed-1+15.8+1+nmu1/debian/changelog    2024-12-28 
13:03:20.000000000 +0100
@@ -1,3 +1,11 @@
+shim-helpers-arm64-signed (1+15.8+1+nmu1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Make the package build without root.
+    (Closes: #1089433)
+
+ -- Niels Thykier <ni...@thykier.net>  Sat, 28 Dec 2024 12:03:20 +0000
+
 shim-helpers-arm64-signed (1+15.8+1) unstable; urgency=medium
 
   * Update to shim 15.8-1
diff -Nru shim-helpers-arm64-signed-1+15.8+1/debian/control 
shim-helpers-arm64-signed-1+15.8+1+nmu1/debian/control
--- shim-helpers-arm64-signed-1+15.8+1/debian/control   2024-05-05 
00:29:52.000000000 +0200
+++ shim-helpers-arm64-signed-1+15.8+1+nmu1/debian/control      2024-12-28 
13:03:16.000000000 +0100
@@ -2,6 +2,7 @@
 Section: admin
 Priority: optional
 Maintainer: Debian EFI team <debian-...@lists.debian.org>
+Rules-Requires-Root: no
 Standards-Version: 4.3.0
 Build-Depends: debhelper (>= 10.1~),
  sbsigntool [amd64 arm64 i386],
diff -Nru shim-helpers-arm64-signed-1+15.8+1/debian/rules 
shim-helpers-arm64-signed-1+15.8+1+nmu1/debian/rules
--- shim-helpers-arm64-signed-1+15.8+1/debian/rules     2024-05-05 
00:29:52.000000000 +0200
+++ shim-helpers-arm64-signed-1+15.8+1+nmu1/debian/rules        2024-12-28 
13:03:01.000000000 +0100
@@ -9,8 +9,8 @@
        set -e ; \
        find "$(SIG_DIR)" -name '*.sig' -printf '%P\n' | \
        while read sig; do \
-               install -o 0 -g 0 -m 0755 -d "debian/tmp/$${sig%/*}" ; \
-               install -o 0 -g 0 -m 0644 "/$${sig%.sig}" 
"debian/tmp/$${sig}ned" ; \
+               install -m 0755 -d "debian/tmp/$${sig%/*}" ; \
+               install -m 0644 "/$${sig%.sig}" "debian/tmp/$${sig}ned" ; \
                sbattach --attach "$(SIG_DIR)/$$sig" "debian/tmp/$${sig}ned" ; \
        done
 

OpenPGP_signature.asc
Description: OpenPGP digital signature