Hi Chris!

On Wed, Dec 18, 2024 at 10:40:35AM +0000, Chris Lamb wrote:
> Dear Maintainer,
>
> I think there might be a regression in the handling of datetimes in
> the latest version of Sphinx, causing a large number of packages to
> become unreproducible.
>
> For example, here is python-biom-format that was built with 8.1.3-2:
>
> │ │ │ ├── ./usr/share/doc/python-biom-format-doc/html/BIOM_LICENSE.html
> │ │ │ │ @@ -86,12 +86,12 @@
> │ │ │ │  
> │ │ │ │      <div class="footer" role="contentinfo">
> │ │ │ │      &#169; Copyright 2011-2024 The BIOM Format Development Team.
> │ │ │ │ -      Last updated on May 27, 2024.
> │ │ │ │ +      Last updated on May 28, 2024.
>
> However, this is affecting a large (10s) of packages. I suspect that
> this is related to timezone handling (or lack thereof).

It is probably caused by this change:

https://github.com/sphinx-doc/sphinx/pull/12907

Now, $SOURCE_DATE_EPOCH is assumed to be UTC time, and then it is converted
to the current local time.

What would be the right approach here? Do not perform any time zone
conversions when $SOURCE_DATE_EPOCH is set, i.e. indent the "if local_time"
block by two levels?

--
Dmitry Shachnev

Attachment: signature.asc
Description: PGP signature

Reply via email to