Hello Thomas et al.
I reported this in April this year, and it has been a source of trouble
for the archive rebuilds I do, because there are 18 packages affected
and I always have to account those failures as "false positives".
The failures seem to happen in a purely random fashion (and independent
from one try to another try), and they have *already* happened in
the buildds. This alone is usually enough to consider the bug as RC,
as we don't want packages to build with failures (even if random)
in the buildds, but I've respected your downgrade even if I disagree.
We have considered several things, you were even willing to sacrifice
serial_console.html in version 3:25.1.0-3, but the current patch makes
such thing unnecessary and I believe it's overall better than all
the alternatives.
Many other people at this point would have already considered
NMUing the package to one of the delayed queues, but I don't
like NMUs, you are not MIA, and this package is supposed to
be team maintained.
Therefore, *please*, take a few minutes to consider the attached
patch, which just changes the wording slightly over the previous
one (since "Compressing... " is printed with "echo -n", the logical
continuation is "attempt [...]") but it's otherwise complete,
including changelog entries. I already tested the patch extensively
and the 18 affected packages build ok and without failures after
hundreds of rebuilds.
Alternatively, if you are still unhappy with this patch *please* say so,
but I honestly believe there is little room for improvement.
Thanks.
diff --git a/debian/changelog b/debian/changelog
index 62ee30a36..c84308c95 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+horizon (3:25.1.0-5) unstable; urgency=medium
+
+ * Drop extra semicolon and add missing newline at the end
+ of serial_console.scss.
+ * Make openstack-dashboard postinst to try the compress operation several
+ times, as it seems to fail in a purely random way. Closes: #1069097.
+
+ -- Thomas Goirand <z...@debian.org> Tue, 10 Dec 2024 23:25:00 +0100
+
horizon (3:25.1.0-4) unstable; urgency=medium
* Attempt to fix serial_console.scss instead of removing serial_console.html:
diff --git a/debian/openstack-dashboard.postinst
b/debian/openstack-dashboard.postinst
index d24971322..fc51b7f94 100644
--- a/debian/openstack-dashboard.postinst
+++ b/debian/openstack-dashboard.postinst
@@ -10,7 +10,13 @@ rebuild_static() {
# Compress the JS and CSS with python-compressor and python-lesscpy
if [ -x /usr/share/openstack-dashboard/manage.py ] ; then
/usr/share/openstack-dashboard/manage.py collectstatic
--noinput --clear
- /usr/share/openstack-dashboard/manage.py compress --force
+ for a in 1 2 3 4 5; do
+ if /usr/share/openstack-dashboard/manage.py compress
--force; then
+ break
+ else
+ echo "attempt ${a} failed"
+ fi
+ done
fi
if [ -f /var/lib/openstack-dashboard/secret-key/.secret_key_store ];
then
diff --git a/debian/patches/fix-serial_console.scss.patch
b/debian/patches/fix-serial_console.scss.patch
index d755a892a..7d92d5cff 100644
--- a/debian/patches/fix-serial_console.scss.patch
+++ b/debian/patches/fix-serial_console.scss.patch
@@ -15,3 +15,10 @@ Last-Update: 2024-11-18
}
.terminal {
+@@ -16,4 +16,4 @@
+ .terminal-cursor {
+ color: black;
+ background: white;
+-};
+\ No newline at end of file
++}
