Hi Lukas,

On Mon, Dec 09, 2024 at 01:07:27PM +0100, Lukas Märdian wrote:
> There have been discussions to switch ifupdown from using ISC dhclient to
> dhcpcd, which comes with some slight differences in behavior. 

FYI dhcpcd-base is already Priority:important in sid instead of
dhclient. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1038882#111

> In Ubuntu, the attached patch was applied to achieve the following:
> 
>   * d/t/{get-address+query-dns+lua+alt,ip-addr.patterns}: dhcpcd compat.
>     It does not send the hostname in its default configuration, provides
>     slightly different lease lifetimes and adds the 'noprefixroute' tag to
>     the test address from ip-addr.patterns (compared to ISC dhclient).
> 
> 

> diff -Nru dnsmasq-2.90/debian/tests/functions.d/ip-addr.patterns 
> dnsmasq-2.90/debian/tests/functions.d/ip-addr.patterns
> --- dnsmasq-2.90/debian/tests/functions.d/ip-addr.patterns    2024-11-23 
> 18:50:11.000000000 +0100
> +++ dnsmasq-2.90/debian/tests/functions.d/ip-addr.patterns    2024-12-09 
> 12:50:13.000000000 +0100
> @@ -1,6 +1,6 @@
>  *: veth1@if*: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state 
> UP group default qlen 1000
>      link/ether ??:??:??:??:??:?? brd ff:ff:ff:ff:ff:ff link-netnsid 0
> -    inet 192.168.142.?/29 brd 192.168.142.7 scope global dynamic veth1
> -       valid_lft 3[56][0-9][0-9]sec preferred_lft 3[56][0-9][0-9]sec
> +    inet 192.168.142.?/29 brd 192.168.142.7 scope global dynamic* veth1

The wildcard seems excessive, can we make this more specific? Admittedly
the test driver using shell script patterns here seems bonkers. Bash
supports regex style groups but alas this uses dash.

> +       valid_lft 3[56][0-9][0-9]sec preferred_lft 3[0-9][0-9][0-9]sec
>      inet6 fe80::*:*:*:*/64 scope link*
>         valid_lft forever preferred_lft forever
> diff -Nru dnsmasq-2.90/debian/tests/get-address+query-dns+lua+alt 
> dnsmasq-2.90/debian/tests/get-address+query-dns+lua+alt
> --- dnsmasq-2.90/debian/tests/get-address+query-dns+lua+alt   2024-11-23 
> 18:50:11.000000000 +0100
> +++ dnsmasq-2.90/debian/tests/get-address+query-dns+lua+alt   2024-12-09 
> 12:50:13.000000000 +0100
> @@ -4,6 +4,7 @@
>  
>  . debian/tests/functions
>  
> +echo "hostname" >> /etc/dhcpcd.conf  # Make it work on dhcpcd

This is actually a(nother) regression in dhcpcd-base compared to
dhclient. I've filed #1089598.

>  stop_dnsmasq_bind_networking
>  configure_and_start_networking
>  configure_and_start_bind

--Daniel

Attachment: signature.asc
Description: PGP signature

Reply via email to