Bug#1089464: wide-dhcpv6: Supporting rootless builds by default

Niels Thykier Sat, 07 Dec 2024 13:03:28 -0800

Source: wide-dhcpv6
Version: 20080615-23
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue


Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
wide-dhcpv6 failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
dhcp6s.c: In function ‘process_relayforw’:

dhcp6s.c:1062:25: warning: taking address of packed member of ‘struct dhcp6_relay’ may result in an unaligned pointer value [-Waddress-of-packed-member]

 1062 |             in6addr2str(&dh6relay->dh6relay_linkaddr, 0),
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

dhcp6s.c:1063:25: warning: taking address of packed member of ‘struct dhcp6_relay’ may result in an unaligned pointer value [-Waddress-of-packed-member]

 1063 |             in6addr2str(&dh6relay->dh6relay_peeraddr, 0));
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

gcc -Wl,-z,relro -Wl,-z,now -o dhcp6s dhcp6s.o common.o if.o config.o timer.o lease.o base64.o auth.o dhcp6_ctl.o cfparse.o cftoken.o -ll gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I. -Wdate-time -D_FORTIFY_SOURCE=2 -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DYYTEXT_POINTER=1 -DHAVE_GETADDRINFO=1 -DHAVE_GETNAMEINFO=1 -DHAVE_GETIFADDRS=1 -DHAVE_IF_NAMETOINDEX=1 -DHAVE_STRLCPY=1 -DHAVE_STRLCAT=1 -DHAVE_DAEMON=1 -DHAVE_WARNX=1 -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_TIME_H=1 -DSTDC_HEADERS=1 -DHAVE_FCNTL_H=1 -DHAVE_SYS_IOCTL_H=1 -DHAVE_SYS_TIME_H=1 -DHAVE_SYSLOG_H=1 -DHAVE_UNISTD_H=1 -DHAVE_IFADDRS_H=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_STRUCT_TM_TM_ZONE=1 -DHAVE_TM_ZONE=1 -DHAVE_SIG_ATOMIC_T=1 -DGETPGRP_VOID=1 -DSETPGRP_VOID=1 -DRETSIGTYPE=void -DHAVE_MKTIME=1 -DHAVE_SELECT=1 -DHAVE_SOCKET=1 -DHAVE_CLOCK_GETTIME=1 -DHAVE_ARC4RANDOM=1 -DHAVE_TAILQ_FOREACH_REVERSE_OLD=1 -DHAVE_STDARG_H=1 -DSYSCONFDIR=\"/etc/wide-dhcpv6\" -DLOCALDBDIR=\"/var/lib/dhcpv6\" -Wdate-time -D_FORTIFY_SOURCE=2 -c -o dhcp6relay.o dhcp6relay.c

dhcp6relay.c: In function ‘relay_to_client’:

dhcp6relay.c:946:25: warning: taking address of packed member of ‘struct dhcp6_relay’ may result in an unaligned pointer value [-Waddress-of-packed-member]

  946 |             in6addr2str(&dh6relay->dh6relay_linkaddr, 0),
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

dhcp6relay.c:947:25: warning: taking address of packed member of ‘struct dhcp6_relay’ may result in an unaligned pointer value [-Waddress-of-packed-member]

  947 |             in6addr2str(&dh6relay->dh6relay_peeraddr, 0));
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from dhcp6relay.c:42:

dhcp6relay.c:1007:38: warning: taking address of packed member of ‘struct dhcp6_relay’ may result in an unaligned pointer value [-Waddress-of-packed-member] 1007 | !IN6_IS_ADDR_UNSPECIFIED(&dh6relay->dh6relay_linkaddr) &&

      |                                      ^

dhcp6relay.c:1008:36: warning: taking address of packed member of ‘struct dhcp6_relay’ may result in an unaligned pointer value [-Waddress-of-packed-member]

 1008 |             !IN6_IS_ADDR_LINKLOCAL(&dh6relay->dh6relay_linkaddr)) {
      |                                    ^

dhcp6relay.c:1009:37: warning: taking address of packed member of ‘struct dhcp6_relay’ may result in an unaligned pointer value [-Waddress-of-packed-member] 1009 | if (getifidfromaddr(&dh6relay->dh6relay_linkaddr, &ifid))

      |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I. -Wdate-time -D_FORTIFY_SOURCE=2 -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DYYTEXT_POINTER=1 -DHAVE_GETADDRINFO=1 -DHAVE_GETNAMEINFO=1 -DHAVE_GETIFADDRS=1 -DHAVE_IF_NAMETOINDEX=1 -DHAVE_STRLCPY=1 -DHAVE_STRLCAT=1 -DHAVE_DAEMON=1 -DHAVE_WARNX=1 -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_TIME_H=1 -DSTDC_HEADERS=1 -DHAVE_FCNTL_H=1 -DHAVE_SYS_IOCTL_H=1 -DHAVE_SYS_TIME_H=1 -DHAVE_SYSLOG_H=1 -DHAVE_UNISTD_H=1 -DHAVE_IFADDRS_H=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_STRUCT_TM_TM_ZONE=1 -DHAVE_TM_ZONE=1 -DHAVE_SIG_ATOMIC_T=1 -DGETPGRP_VOID=1 -DSETPGRP_VOID=1 -DRETSIGTYPE=void -DHAVE_MKTIME=1 -DHAVE_SELECT=1 -DHAVE_SOCKET=1 -DHAVE_CLOCK_GETTIME=1 -DHAVE_ARC4RANDOM=1 -DHAVE_TAILQ_FOREACH_REVERSE_OLD=1 -DHAVE_STDARG_H=1 -DSYSCONFDIR=\"/etc/wide-dhcpv6\" -DLOCALDBDIR=\"/var/lib/dhcpv6\" -Wdate-time -D_FORTIFY_SOURCE=2 -c -o dhcp6relay_script.o dhcp6relay_script.c gcc -Wl,-z,relro -Wl,-z,now -o dhcp6relay dhcp6relay.o dhcp6relay_script.o common.o timer.o gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -I. -Wdate-time -D_FORTIFY_SOURCE=2 -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DYYTEXT_POINTER=1 -DHAVE_GETADDRINFO=1 -DHAVE_GETNAMEINFO=1 -DHAVE_GETIFADDRS=1 -DHAVE_IF_NAMETOINDEX=1 -DHAVE_STRLCPY=1 -DHAVE_STRLCAT=1 -DHAVE_DAEMON=1 -DHAVE_WARNX=1 -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_TIME_H=1 -DSTDC_HEADERS=1 -DHAVE_FCNTL_H=1 -DHAVE_SYS_IOCTL_H=1 -DHAVE_SYS_TIME_H=1 -DHAVE_SYSLOG_H=1 -DHAVE_UNISTD_H=1 -DHAVE_IFADDRS_H=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_STRUCT_TM_TM_ZONE=1 -DHAVE_TM_ZONE=1 -DHAVE_SIG_ATOMIC_T=1 -DGETPGRP_VOID=1 -DSETPGRP_VOID=1 -DRETSIGTYPE=void -DHAVE_MKTIME=1 -DHAVE_SELECT=1 -DHAVE_SOCKET=1 -DHAVE_CLOCK_GETTIME=1 -DHAVE_ARC4RANDOM=1 -DHAVE_TAILQ_FOREACH_REVERSE_OLD=1 -DHAVE_STDARG_H=1 -DSYSCONFDIR=\"/etc/wide-dhcpv6\" -DLOCALDBDIR=\"/var/lib/dhcpv6\" -Wdate-time -D_FORTIFY_SOURCE=2 -c -o dhcp6_ctlclient.o dhcp6_ctlclient.c gcc -Wl,-z,relro -Wl,-z,now -o dhcp6ctl dhcp6_ctlclient.o base64.o auth.o make[2]: Leaving directory '/<<PKGBUILDDIR>>/build-udeb'

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_installdirs
   debian/rules override_dh_auto_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
/usr/bin/make -C build prefix=/<<PKGBUILDDIR>>/debian/tmp/usr install
make[2]: Entering directory '/<<PKGBUILDDIR>>/build'

mkdir -p /<<PKGBUILDDIR>>/debian/tmp/usr/sbin /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man5 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man8 /usr/bin/install -c -o bin -g bin dhcp6c dhcp6s dhcp6relay dhcp6ctl /<<PKGBUILDDIR>>/debian/tmp/usr/sbin /usr/bin/install: cannot change ownership of '/<<PKGBUILDDIR>>/debian/tmp/usr/sbin/dhcp6c': Operation not permitted /usr/bin/install: cannot change ownership of '/<<PKGBUILDDIR>>/debian/tmp/usr/sbin/dhcp6s': Operation not permitted /usr/bin/install: cannot change ownership of '/<<PKGBUILDDIR>>/debian/tmp/usr/sbin/dhcp6relay': Operation not permitted /usr/bin/install: cannot change ownership of '/<<PKGBUILDDIR>>/debian/tmp/usr/sbin/dhcp6ctl': Operation not permitted

make[2]: *** [Makefile:111: install] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/build'
make[1]: *** [debian/rules:31: override_dh_auto_install] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:12: binary] Error 2

dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

--------------------------------------------------------------------------------
Build finished at 2024-11-18T20:21:56Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1051013.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089464: wide-dhcpv6: Supporting rootless builds by default

Reply via email to