Hi!

On Thu, 2024-11-28 at 01:11:05 +0100, Santiago Vila wrote:
> The attached patch (which I've tried it to be as minimal as possible)
> would make dh_buildinfo a no-op, as discussed in this thread.
> 
> This would remove its undesired effects. Most notably, the ones related to
> reproducibility pointed out by Holger, where the smallest change
> in the build environment makes a package to be different again,
> and it would achieve it with mininal fuss, as we would not need
> sourceful uploads for hundreds of packages.

I think that would be a nice incremental improvement with immediate
benefits, which does not preclude the cleanup that Holger was talking
about, which can then run at its own independent course. I think
people agreeing with this was more about untangling the concerns,
more than not considering the cleanup worthwhile.

On Thu, 2024-11-28 at 01:33:12 +0100, Santiago Vila wrote:
> Sorry, I forgot the patch. Here it is.

> --- /dev/null
> +++ b/debian/dummy_dh_buildinfo
> @@ -0,0 +1,2 @@
> +#!/bin/sh
> +echo "Warning: dh-buildinfo is obsolete, please remove it from Build-Depends"

Perhaps using instead the following, would give a bit more visibility
to the warning:

,--- dh_buildinfo ---
#!/bin/sh

PROGNAME=dh_buildinfo
. /usr/share/dpkg/sh/dpkg-error.sh
setup_colors

warning "dh-buildinfo is obsolete, please remove it from Build-Depends"
`---

(I've been bothered by the seemingly gratuitous boilerplate required
for dpkg-error.sh in the past, but this now made that resurface, so
I'm working on reducing it in dpkg git, for future similar usages. :)

Thanks,
Guillem

Reply via email to