Bug#1088960: fsarchiver: potential incompatibility with e2fsprogs 1.47.2

[Michael Biebl]

Thanks for the patch. Will see if I can update the package this weekend.


Am 04.12.24 um 20:00 schrieb Theodore Ts'o:

On Wed, Dec 04, 2024 at 01:24:39PM +0100, Michael Biebl wrote:

Patching fsarchiver to use -E revision=0 (or rather try both as I can't
assume I have a new e2fsprogs) could be an option if someone provided a
patch. Are you willing to work on such a patch?

This patch compiles, but has not been tested.

"It builds, ship it!"  :-)

                                        - Ted

--- src/fs_ext2.c.orig  2024-12-04 13:54:30.230764953 -0500
+++ src/fs_ext2.c       2024-12-04 13:58:02.545015510 -0500
@@ -349,7 +349,10 @@
      strlcatf(options, sizeof(options), " -I %ld ", (long)devisize);

-    strlcatf(options, sizeof(options), " -r %d ", (int)fsextrevision);
+    if (e2fstoolsver<=PROGVER(1,47,2))

// filesystem revision: good-old-rev or dynamic

I guess this needs to be "<", not "<=", right?

+        strlcatf(options, sizeof(options), " -r %d ", (int)fsextrevision);
+    else
+        strlcatf(options, sizeof(options), " -E revision=%d ", 
(int)fsextrevision);

      if (fsextrevision!=EXT2_GOOD_OLD_REV && strlist_count(&strfeatures)>0)

// if extfs revision is dynamic and there are features in the list

Will you revert https://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/commit/?id=bb3b4c2265d1870d7efa4ad03e6a2eb649675255 again if I apply this change to fsarchive or do you intend to keep this patch in e2fsprogs?

Michael

OpenPGP_signature.asc
Description: OpenPGP digital signature