Package: plymouth
Severity: medium

Hello,

In several postinst and postrm scripts, update-initramfs is being called manually instead of being called via dpkg-trigger. This results in systems with Dracut as the default to not receive an initramfs update when Plymouth is updated.

I have attached a diff (which is now also in the Ubuntu delta) which fixes this. I have tested it with both initramfs-tools and dracut, and both now generate an initramfs properly on Plymouth updates.

Thanks,
--
Simon Quigley
si...@tsimonq2.net
@tsimonq2:ubuntu.com on Matrix
tsimonq2 on LiberaChat and OFTC
5C7A BEA2 0F86 3045 9CC8
C8B5 E27F 2CF8 458C 2FA4

diff -Nru plymouth-24.004.60/debian/plymouth.postinst plymouth-24.004.60/debian/plymouth.postinst
--- plymouth-24.004.60/debian/plymouth.postinst	2024-11-07 19:18:28.000000000 -0600
+++ plymouth-24.004.60/debian/plymouth.postinst	2024-11-24 00:26:27.000000000 -0600
@@ -4,9 +4,7 @@
 
 case "${1}" in
 	configure)
-		if which update-initramfs >/dev/null 2>&1; then
-			update-initramfs -u -k all
-		fi
+		dpkg-trigger update-initramfs
 		;;
 
 	abort-upgrade|abort-remove|abort-deconfigure)
diff -Nru plymouth-24.004.60/debian/plymouth.postrm plymouth-24.004.60/debian/plymouth.postrm
--- plymouth-24.004.60/debian/plymouth.postrm	2024-07-17 11:39:45.000000000 -0500
+++ plymouth-24.004.60/debian/plymouth.postrm	2024-11-24 00:27:59.000000000 -0600
@@ -11,9 +11,7 @@
 		if [ -L '/sbin/plymouthd' ]; then
 			rm /sbin/plymouthd
 		fi
-		if which update-initramfs >/dev/null 2>&1 && [ -e /etc/initramfs-tools/initramfs.conf ]; then
-			update-initramfs -u -k all
-		fi
+		dpkg-trigger update-initramfs
 		;;
 	purge)
 		rm -f /var/lib/plymouth/boot-duration
diff -Nru plymouth-24.004.60/debian/plymouth-theme-spinner.postinst plymouth-24.004.60/debian/plymouth-theme-spinner.postinst
--- plymouth-24.004.60/debian/plymouth-theme-spinner.postinst	2024-09-04 10:46:15.000000000 -0500
+++ plymouth-24.004.60/debian/plymouth-theme-spinner.postinst	2024-11-24 00:26:42.000000000 -0600
@@ -23,10 +23,7 @@
 		--install /usr/share/plymouth/themes/default.plymouth default.plymouth \
 		/usr/share/plymouth/themes/bgrt/bgrt.plymouth 110
 
-	if which update-initramfs >/dev/null 2>&1
-	then
-	    update-initramfs -u
-	fi
+	dpkg-trigger update-initramfs
 
 	if [ -e /boot/grub/grub.cfg ] && which update-grub >/dev/null 2>&1; then
 		update-grub || true
diff -Nru plymouth-24.004.60/debian/plymouth-theme-spinner.postrm plymouth-24.004.60/debian/plymouth-theme-spinner.postrm
--- plymouth-24.004.60/debian/plymouth-theme-spinner.postrm	2024-09-04 10:46:15.000000000 -0500
+++ plymouth-24.004.60/debian/plymouth-theme-spinner.postrm	2024-11-24 00:28:10.000000000 -0600
@@ -3,10 +3,7 @@
 set -e
 
 if [ "x$1" = xremove ]; then
-	if which update-initramfs >/dev/null 2>&1
-	then
-		update-initramfs -u
-	fi
+	dpkg-trigger update-initramfs
 
 	if [ -e /boot/grub/grub.cfg ] && which update-grub >/dev/null 2>&1; then
 		update-grub || true
diff -Nru plymouth-24.004.60/debian/plymouth-themes.postinst plymouth-24.004.60/debian/plymouth-themes.postinst
--- plymouth-24.004.60/debian/plymouth-themes.postinst	2024-11-07 19:18:29.000000000 -0600
+++ plymouth-24.004.60/debian/plymouth-themes.postinst	2024-11-24 00:26:57.000000000 -0600
@@ -12,9 +12,7 @@
       --install /usr/share/plymouth/themes/text.plymouth text.plymouth \
       /usr/share/plymouth/themes/text/text.plymouth 40
 
-		if which update-initramfs >/dev/null 2>&1; then
-			update-initramfs -u -k all
-		fi
+		dpkg-trigger update-initramfs
 		;;
 
 	abort-upgrade|abort-remove|abort-deconfigure)
diff -Nru plymouth-24.004.60/debian/plymouth-themes.postrm plymouth-24.004.60/debian/plymouth-themes.postrm
--- plymouth-24.004.60/debian/plymouth-themes.postrm	2024-11-07 19:18:28.000000000 -0600
+++ plymouth-24.004.60/debian/plymouth-themes.postrm	2024-11-24 00:28:18.000000000 -0600
@@ -4,9 +4,7 @@
 
 case "${1}" in
 	remove)
-		if which update-initramfs >/dev/null 2>&1; then
-			update-initramfs -u -k all
-		fi
+		dpkg-trigger update-initramfs
 		;;
 
 	purge|upgrade|failed-upgrade|abort-install|abort-upgrade|disappear)
diff -Nru plymouth-24.004.60/debian/plymouth-theme-ubuntu-logo.postinst plymouth-24.004.60/debian/plymouth-theme-ubuntu-logo.postinst
--- plymouth-24.004.60/debian/plymouth-theme-ubuntu-logo.postinst	2024-09-04 10:46:15.000000000 -0500
+++ plymouth-24.004.60/debian/plymouth-theme-ubuntu-logo.postinst	2024-11-24 00:27:07.000000000 -0600
@@ -24,10 +24,7 @@
 		--slave /usr/share/plymouth/themes/default.grub default.plymouth.grub \
 		/usr/share/plymouth/themes/ubuntu-logo/ubuntu-logo.grub
 
-	if which update-initramfs >/dev/null 2>&1
-	then
-	    update-initramfs -u
-	fi
+	dpkg-trigger update-initramfs
 	;;
 
     abort-upgrade|abort-deconfigure|abort-remove)
diff -Nru plymouth-24.004.60/debian/plymouth-theme-ubuntu-logo.postrm plymouth-24.004.60/debian/plymouth-theme-ubuntu-logo.postrm
--- plymouth-24.004.60/debian/plymouth-theme-ubuntu-logo.postrm	2024-09-04 10:46:15.000000000 -0500
+++ plymouth-24.004.60/debian/plymouth-theme-ubuntu-logo.postrm	2024-11-24 00:28:29.000000000 -0600
@@ -3,10 +3,7 @@
 set -e
 
 if [ "x$1" = xremove ]; then
-	if which update-initramfs >/dev/null 2>&1
-	then
-		update-initramfs -u
-	fi
+	dpkg-trigger update-initramfs
 fi
 
 #DEBHELPER#
diff -Nru plymouth-24.004.60/debian/plymouth-theme-ubuntu-text.postinst plymouth-24.004.60/debian/plymouth-theme-ubuntu-text.postinst
--- plymouth-24.004.60/debian/plymouth-theme-ubuntu-text.postinst	2024-09-04 10:46:15.000000000 -0500
+++ plymouth-24.004.60/debian/plymouth-theme-ubuntu-text.postinst	2024-11-24 00:27:17.000000000 -0600
@@ -34,10 +34,7 @@
 		--install /usr/share/plymouth/themes/text.plymouth text.plymouth \
 		/usr/share/plymouth/themes/ubuntu-text/ubuntu-text.plymouth 50
 
-	if which update-initramfs >/dev/null 2>&1
-	then
-	    update-initramfs -u
-	fi
+	dpkg-trigger update-initramfs
 	;;
 
     abort-upgrade|abort-deconfigure|abort-remove)
diff -Nru plymouth-24.004.60/debian/plymouth-theme-ubuntu-text.postrm plymouth-24.004.60/debian/plymouth-theme-ubuntu-text.postrm
--- plymouth-24.004.60/debian/plymouth-theme-ubuntu-text.postrm	2024-09-04 10:46:15.000000000 -0500
+++ plymouth-24.004.60/debian/plymouth-theme-ubuntu-text.postrm	2024-11-24 00:28:36.000000000 -0600
@@ -3,10 +3,7 @@
 set -e
 
 if [ "x$1" = xremove ]; then
-	if which update-initramfs >/dev/null 2>&1
-	then
-		update-initramfs -u
-	fi
+	dpkg-trigger update-initramfs
 fi
 
 #DEBHELPER#
diff -Nru plymouth-24.004.60/debian/plymouth-x11.postinst plymouth-24.004.60/debian/plymouth-x11.postinst
--- plymouth-24.004.60/debian/plymouth-x11.postinst	2024-11-07 19:18:28.000000000 -0600
+++ plymouth-24.004.60/debian/plymouth-x11.postinst	2024-11-24 00:27:26.000000000 -0600
@@ -4,9 +4,7 @@
 
 case "${1}" in
 	configure)
-		if which update-initramfs >/dev/null 2>&1; then
-			update-initramfs -u -k all
-		fi
+		dpkg-trigger update-initramfs
 		;;
 
 	abort-upgrade|abort-remove|abort-deconfigure)
diff -Nru plymouth-24.004.60/debian/plymouth-x11.postrm plymouth-24.004.60/debian/plymouth-x11.postrm
--- plymouth-24.004.60/debian/plymouth-x11.postrm	2024-11-07 19:18:28.000000000 -0600
+++ plymouth-24.004.60/debian/plymouth-x11.postrm	2024-11-24 00:28:44.000000000 -0600
@@ -4,9 +4,7 @@
 
 case "${1}" in
 	remove)
-		if which update-initramfs >/dev/null 2>&1; then
-			update-initramfs -u -k all
-		fi
+		dpkg-trigger update-initramfs
 		;;
 
 	purge|upgrade|failed-upgrade|abort-install|abort-upgrade|disappear)

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to