On Wed, 30 Oct 2024 11:58:34 +1100 Craig Small <csm...@debian.org> wrote:
> The logcheck rule for system CPU time misses the new memory peak part. > > Current line in ignore.d.server/systemd: > # possibly > https://sources.debian.org/src/systemd/252.4-1/src/core/unit.c/#L2307 (line > 2474 converts the "consumed"->"Consumed")? > ^([[:alpha:]]{3} [ :[:digit:]]{11}|[0-9T:.+-]{32}) [._[:alnum:]-]+ > systemd\[[0-9]+\]: [^ ]+: Consumed .+ CPU time\.$ > > However logcheck prints things like: > Oct 30 00:00:09 elmo systemd[1]: debci-update.service: Consumed 1.107s CPU > time, 46.7M memory peak. > > Suggested change: > ^([[:alpha:]]{3} [ :[:digit:]]{11}|[0-9T:.+-]{32}) [._[:alnum:]-]+ > systemd\[[0-9]+\]: [^ ]+: Consumed .+ CPU time(, .+ memory peak)?\.$ Looks good to me. Looking at https://salsa.debian.org/systemd-team/systemd/-/blob/debian/master/src/core/unit.c/#L2308 i think, if i understand lines 2350 and 2377, that it can also include a 'memory swap peak' as well(?), but presumably that is rare enough we shouldn't include it to the rule
