Control: tags -1 +moreinfo

Benoit,

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Issue

Running lintian...
N:
W: qabc: spelling-error-in-changelog upsteam upstream
[usr/share/doc/qabc/changelog.Debian.gz:1]
N: 
N:   Lintian found a spelling error in the latest entry of the Debian
N:   changelog. Lintian has a list of common misspellings that it looks for.
It
N:   does not have a dictionary like a spelling checker does.
N:   
N:   When writing a changelog entry for a spelling fix that includes the
N:   misspelling, ensure the word "spelling" is on the same line as the
N:   misspelled word to avoid triggering this warning.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: debian/changelog
N: 
N:
I: qabc source: debian-watch-uses-insecure-uri
http://brouits.free.fr/qabc/qabc-(.+)\.tar\.gz [debian/watch:2]
N: 
N:   The watch file uses an unencrypted transport protocol for the URI such
as
N:   http:// or ftp://. It is recommended to use a secure transport such as
N:   HTTPS for anonymous read-only access.
N:   
N:   Upstream may already provide a HTTPS variant of the URI. If not, please
N:   contact them and ask them to consider adding one.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/watch
N: 
N:
I: qabc: spelling-error-in-description "allow to" "allow one to"
N: 
N:   Lintian found a spelling error in the package description. Lintian has a
N:   list of common misspellings that it looks for. It does not have a
N:   dictionary like a spelling checker does. It is particularly picky about
N:   spelling and capitalization in package descriptions since they're very
N:   visible to end users.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/description
N: 
N:
I: qabc: typo-in-manual-page "allow to" "allow one to"
[usr/share/man/man1/qabc.1.gz:11]
N: 
N:   Lintian found a spelling error in a manual page. Lintian has a list of
N:   common misspellings that it looks for. It does not have a dictionary
like
N:   a spelling checker does.
N:   
N:   If the string containing the spelling error is translated with the help
of
N:   gettext (with the help of po4a, for example) or a similar tool, please
fix
N:   the error in the translations as well as the English text to avoid
making
N:   the translations fuzzy. With gettext, for example, this means you should
N:   also fix the spelling mistake in the corresponding msgids in the *.po
N:   files.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: documentation/manual
N:   Renamed from: spelling-error-in-manpage
N: 

I: Lintian run was successful.

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

Summary...

Package is in good shape, just a few lintian issues that need to be addressed
prior to review/sponsorship by a DD.

I believe qabc is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Donations...

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Liberapay: https://liberapay.com/kathenas

--

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Threads: https://www.threads.net/@kathenasorg

--












Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to