Package: vbindiff Version: 3.0-beta5-2 Severity: important Tags: a11y X-Debbugs-Cc: sau...@saurik.com
Dear Maintainer, I have been a user of vbindiff for probably at least 20 years now. I'd even note that I've helped its (very low) popularity by advocating for its usage over the years as well as making sure it was available -- as the /only/ hex editor provided -- on platforms that I've been in charge of (such as Cydia). I recently started using a new version of Debian, and was dismayed that the primary reason for its existence -- being able to quickly visualize changes between two similar files -- has been made extremely difficult to correctly use, as the color of such changes has changed from red to green... on blue, vs. the default text color of off-white. This is extremely little contrast for such a primary/critical purpose of this long-standing piece of software. I searched for the issue, but all I found was another person noticing this. https://old.reddit.com/r/linux4noobs/comments/1euhxu0/upgraded_my_mint_installation_from_21_to_22/ I couldn't see anything in upstream that could have changed in recent years, so I looked through the Debian-specific paches... and, sure enough, there is one which changes the color used from red to green as part of adding a new feature involving highlighting search results (which is now clobbering red). Digging a bit more, it seems that a number of patches were contributed by a user named linuxCowboy, drifting the copy of vbindiff on Debian quite a bit from both upstream and other systems (including, for example, on Homebrew). This user seems to have their own fork of vbindiff--"for Linux"--and so if they want to do development work on vbindiff I'd think they should do it on their fork, not attempt to add a bunch of new functionality just to Debian. https://github.com/linuxCowboy/vbl I say this particularly so as more of these patches are just strange / bad. Like, one of these patches makes vbindiff refuse to open empty files. Why? It works fine on empty files, supporting not only diff but editing; making a hex editor refuse to open an empty file feels akin to a text editor--or a tool like diff--only working on files that already have text to edit/diff. Another of these patches adds functionality that requires you to recompile the binary using a different #define. Is that even relevant for Debian? ;P Can we maybe just roll back all of these patches for a nice/clean vbindiff? -- System Information: Debian Release: trixie/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 6.10.9-cloud-amd64 (SMP w/8 CPU threads; PREEMPT) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages vbindiff depends on: ii libc6 2.40-2 ii libgcc-s1 14.2.0-5 ii libncurses6 6.5-2 ii libstdc++6 14.2.0-5 ii libtinfo6 6.5-2 vbindiff recommends no packages. vbindiff suggests no packages. -- no debconf information
