Hello, Sorry for some reason I was never subscribed to this bug. I am CC'ing you all in case that happens for you too.
On Thu, 24 Oct 2024 11:26:09 +0100 Hibby <hi...@debian.org> wrote: > Alex, > > I see there's a new upload this morning with updated upstream - does it address this bug? The bug does not look to be addressed, and the updated source does not look to be in Salsa. > > Chris, > Development is happening on the master branch, not main [1] - you could try an MR against that when it's updated with this morning's upload. > > [1] https://salsa.debian.org/debian/meshtastic/-/tree/master/debian?ref_type=heads Thanks! That helped me figure out where to make the MR. Since it looks to still be for 2.5.0, I just used the older debdiff to put an MR in: https://salsa.debian.org/debian/meshtastic/-/merge_requests/1 I can update when Salsa has the new change. > ** > Cheers, > DH > > -- > Dave Hibberd > Debian Developer > Packet Radioist > MM0RFN > > On Sat, 19 Oct 2024, at 5:44 PM, Hibby wrote: > > Hi All! > > > > Chris - thanks for the recommendation. > > > > Alex - I've prepared an update to 2.5.0-2 and with that created the attached debdiff - am I ok to upload this as a hamradio team upload? I'll set a reminder to do it next weekend if I don't hear back. > > > > Can I also upload that version to salsa or do you have a local repo that you're maintaining you'd like to upload? > > > > Cheers, > > > > Hibby > > > > -- > > Hibby > > MM0RFN > > > > On Thu, 3 Oct 2024, at 3:20 AM, Chris Talbot wrote: > > > Hello, > > > > > > It looks like print_color is used in only one place, and the following > > > diff should get rid of the dependency: > > > ``` > > > diff --git a/meshtastic/mesh_interface.py > > > b/meshtastic/mesh_interface.py > > > index db057a3..e8950a7 100644 > > > --- a/meshtastic/mesh_interface.py > > > +++ b/meshtastic/mesh_interface.py > > > @@ -14,7 +14,6 @@ from decimal import Decimal > > > from typing import Any, Callable, Dict, List, Optional, Union > > > > > > import google.protobuf.json_format > > > -import print_color # type: ignore[import-untyped] > > > from pubsub import pub # type: ignore[import-untyped] > > > from tabulate import tabulate > > > > > > @@ -153,17 +152,7 @@ class MeshInterface: # pylint: disable=R0902 > > > def _printLogLine(line, interface): > > > """Print a line of log output.""" > > > if interface.debugOut == sys.stdout: > > > - # this isn't quite correct (could cause false positives), > > > but currently our formatting differs between different log -- Respectfully, Chris Talbot
