Source: sqlalchemy
Version: 2.0.32+ds1-1
Severity: normal
Tags: patch
X-Debbugs-Cc: cru...@debian.org

Dear Piotr,

Thank you for removing the mypy related tests in your recent upload. I noticed 
that sqlalchemy still has a build and test dependency on mypy, which is 
triggering unnecessary CI tests (one of which is timing out and causing a 
problem for the migration of the new version of mypy to Debian Testing).

Can you apply the attached patch and release a new package of sqlalchemy?

https://qa.debian.org/excuses.php?package=mypy
https://ci.debian.net/packages/s/sqlalchemy/testing/arm64/53571095/

Many thanks,

--
Michael R. Crusoe
From acd15456dc4833519a8795b73bee93b8077fea5b Mon Sep 17 00:00:00 2001
From: "Michael R. Crusoe" <cru...@debian.org>
Date: Fri, 25 Oct 2024 12:15:09 +0200
Subject: [PATCH] drop dependency on python3-mypy

and instruct pytest to not even load the related tests so that an
error is not triggered
---
 debian/control         | 1 -
 debian/rules           | 2 +-
 debian/tests/control   | 1 -
 debian/tests/unittests | 2 +-
 4 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/debian/control b/debian/control
index 04f2b766..7f875b86 100644
--- a/debian/control
+++ b/debian/control
@@ -8,7 +8,6 @@ Build-Depends: debhelper-compat (= 13),
  python3-all-dev,
  python3-setuptools,
  python3-greenlet,
- python3-mypy (>= 0.910),
  python3-typing-extensions (>= 4.6.0),
 # Documentation:
  python3-changelog (>= 0.5.3),
diff --git a/debian/rules b/debian/rules
index 1ef40613..90be8542 100755
--- a/debian/rules
+++ b/debian/rules
@@ -24,7 +24,7 @@ override_dh_auto_install:
 ifeq (,$(findstring nocheck, $(DEB_BUILD_OPTIONS)))
 	set -e ; set -x ; for i in $(PY3VERS) ; do \
 		PYTHONPATH=$(CURDIR)/debian/python3-sqlalchemy/usr/lib/python3/dist-packages python$$i -m pytest test\
-		-k 'not test_joined_across and not test_eager_join and not test_plugin_files'; \
+		-k 'not test_joined_across and not test_eager_join' --ignore-glob="*mypy*" ; \
 	done
 endif
 
diff --git a/debian/tests/control b/debian/tests/control
index 7c4c6e6b..e55e99cb 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -3,6 +3,5 @@ Depends:
  python3-all,
  python3-greenlet,
  python3-pytest,
- python3-mypy,
  python3-typing-extensions,
 Restrictions: allow-stderr
diff --git a/debian/tests/unittests b/debian/tests/unittests
index b261ca60..d82e66c9 100644
--- a/debian/tests/unittests
+++ b/debian/tests/unittests
@@ -6,5 +6,5 @@ set -e
 echo "===> Running tests"
 for i in ${PYTHON3S}; do
 	echo "===> Testing with python$i"
-	python$i -m pytest --ignore=.pc
+	python$i -m pytest --ignore=.pc --ignore-glob="*mypy*"
 done
-- 
2.43.0

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to