Bug#1046091: yggdrasil: Fails to build source after successful build

[Andres Salomon]

On Sun, 13 Aug 2023 21:21:34 +0200 Lucas Nussbaum <lu...@debian.org> wrote:

Source: yggdrasil
Version: 0.4.7-1
Severity: minor
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian...@lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env 
-us -uc -rfakeroot -S
> 
-------------------------------------------------------------------------------------------------------------------------

> dpkg-buildpackage: info: source version 0.4.7-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by John Goerzen 
<jgoer...@complete.org>
>  dpkg-source --before-build .
>  debian/rules clean
> make: 'clean' is up to date.
>  dpkg-source -b .
> dpkg-source: error: unwanted binary file: debian/yggdrasil/usr/sbin/yggdrasil
> dpkg-source: error: unwanted binary file: 
debian/yggdrasil/usr/sbin/yggdrasilctl
> dpkg-source: error: unwanted binary file: 
debian/yggdrasil/usr/sbin/yggdrasil-genkeys
> dpkg-source: error: unwanted binary file: 
debian/yggdrasil/usr/share/doc/yggdrasil/changelog.Debian.gz
> dpkg-source: error: unwanted binary file: 
debian/yggdrasil/usr/share/doc/yggdrasil/changelog.gz
> dpkg-source: error: unwanted binary file: 
debian/.debhelper/yggdrasil/dbgsym-root/usr/lib/debug/.build-id/fe/d266255a634ce28ba3ff12e6e258d91951ba74.debug
> dpkg-source: error: unwanted binary file: 
debian/.debhelper/yggdrasil/dbgsym-root/usr/lib/debug/.build-id/bb/87556621a1a7882768421d164df6efb403b433.debug
> dpkg-source: error: unwanted binary file: 
debian/.debhelper/yggdrasil/dbgsym-root/usr/lib/debug/.build-id/01/a9a5e3ab44ef57c9a327c882e5377ad329f58b.debug
> dpkg-source: error: unwanted binary file: 
debian/golang-github-yggdrasil-network-yggdrasil-go-dev/usr/share/doc/golang-github-yggdrasil-network-yggdrasil-go-dev/changelog.Debian.gz
> dpkg-source: error: unwanted binary file: 
debian/golang-github-yggdrasil-network-yggdrasil-go-dev/usr/share/doc/golang-github-yggdrasil-network-yggdrasil-go-dev/changelog.gz
> dpkg-source: error: detected 10 unwanted binary files (add them in 
debian/source/include-binaries to allow their inclusion).
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 255



The full build log is available from:
http://qa-logs.debian.net/2023/08/13/yggdrasil_0.4.7-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

> > dpkg-buildpackage: info: source package yggdrasil > > E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.

root@hm90:/yggdrasil-0.5.8# cat clean
#!/bin/sh
git clean -dxf
root@hm90:/yggdrasil-0.5.8#

root@hm90:/yggdrasil-0.5.8# ./debian/rules clean
make: 'clean' is up to date.
root@hm90:/yggdrasil-0.5.8# rm clean
root@hm90:/yggdrasil-0.5.8# ./debian/rules clean
dh clean --builddirectory=_build --buildsystem=golang --with=golang
   dh_auto_clean -O--builddirectory=_build -O--buildsystem=golang
   dh_autoreconf_clean -O--builddirectory=_build -O--buildsystem=golang
   dh_clean -O--builddirectory=_build -O--buildsystem=golang
root@hm90:/yggdrasil-0.5.8#

FYI, this is caused by the existence of a 'clean' script in the top level directory that prevents the clean target in d/rules from calling out to debhelper (and thus allowing debhelper to actually clean up after itself). I don't know your gbp workflow, but a quick 'quilt new clean.patch; quilt add clean; rm clean; quilt refresh;' allows 'dpkg-buildpackge -S' to successfully build a source package after having built a binary package.

OpenPGP_signature.asc
Description: OpenPGP digital signature