On Tue, Oct 15, 2024 at 02:33:48PM +0200, Raphaël Hertzog wrote: > Since a few weeks, gdm was no longer starting right ahead. It was waiting > for network-online.target to be finished. > > I figured out that it was due to yubihsm-connector.service (at least the > problem went away when I purged the package): it marks itself > "After=network-online.target" and as "WantedBy=multi-user.target". > > I'm not exactly sure how that ends up being in the dependency tree > of gdm however... but I question the need of network-online.target. > This is a daemon, it doesn't need outbound access, I assume > "After=network.target" should be sufficient.
Looks like this comes from upstream. I agree network-online.target isn't necessary for the default and common case where you're just listening on 127.0.0.1. I think using network.target would be a problem if you set a different listen address in yubihsm-connector.yaml, though; Go doesn't seem to do IP_FREEBIND. I guess we could patch it to use network.target and add a comment to say that you might need to change that if you use a different listen address? And either way, I don't think I see a justification for Wants=systemd-networkd-wait-online.service - that unit has Before=network-online.target, so specifying it explicitly seems redundant. -- Colin Watson (he/him) [[email protected]]
